Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards

CommentFileSizeAuthor
#6 views-rename_is_value_empty-2002880-6.patch5.69 KBjeroent
#4 views-rename_is_value_empty-2002880-4.patch5.68 KBjeroent
#2 drupal8views-replace_is_value_empty-2002880-02.patch5.67 KBtoddtomlinson

Comments

toddtomlinson’s picture

toddtomlinson commented
Assigned: Unassigned » toddtomlinson
toddtomlinson’s picture

toddtomlinson commented
Status: Active » Needs review
StatusFileSize
new drupal8views-replace_is_value_empty-2002880-02.patch5.67 KB

Patch to replace is_value_empty attached.

Status: Needs review » Needs work

The last submitted patch, drupal8views-replace_is_value_empty-2002880-02.patch, failed testing.

jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented
Status: Needs work » Needs review
StatusFileSize
new views-rename_is_value_empty-2002880-4.patch5.68 KB

Status: Needs review » Needs work

The last submitted patch, views-rename_is_value_empty-2002880-4.patch, failed testing.

jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented
StatusFileSize
new views-rename_is_value_empty-2002880-6.patch5.69 KB

rename is_value_empty() to isValueEmpty(). I hope this works.

jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented
Status: Needs work » Needs review

Marking as needs review.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

Seems fine

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 3888a2b and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.