Files: 
CommentFileSizeAuthor
#6 views-rename_is_value_empty-2002880-6.patch5.69 KBJeroenT
PASSED: [[SimpleTest]]: [MySQL] 56,048 pass(es). View
#4 views-rename_is_value_empty-2002880-4.patch5.68 KBJeroenT
FAILED: [[SimpleTest]]: [MySQL] 57,345 pass(es), 1 fail(s), and 0 exception(s). View
#2 drupal8views-replace_is_value_empty-2002880-02.patch5.67 KBtoddtomlinson
FAILED: [[SimpleTest]]: [MySQL] Setup environment: failed to create checkout database. View

Comments

toddtomlinson’s picture

Assigned: Unassigned » toddtomlinson
toddtomlinson’s picture

Status: Active » Needs review
FileSize
5.67 KB
FAILED: [[SimpleTest]]: [MySQL] Setup environment: failed to create checkout database. View

Patch to replace is_value_empty attached.

Status: Needs review » Needs work

The last submitted patch, drupal8views-replace_is_value_empty-2002880-02.patch, failed testing.

JeroenT’s picture

Status: Needs work » Needs review
FileSize
5.68 KB
FAILED: [[SimpleTest]]: [MySQL] 57,345 pass(es), 1 fail(s), and 0 exception(s). View

Status: Needs review » Needs work

The last submitted patch, views-rename_is_value_empty-2002880-4.patch, failed testing.

JeroenT’s picture

FileSize
5.69 KB
PASSED: [[SimpleTest]]: [MySQL] 56,048 pass(es). View

rename is_value_empty() to isValueEmpty(). I hope this works.

JeroenT’s picture

Status: Needs work » Needs review

Marking as needs review.

dawehner’s picture

Status: Needs review » Reviewed & tested by the community

Seems fine

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed 3888a2b and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.