Files: 
CommentFileSizeAuthor
#16 2002500-rename-exposed-form-validate-16.patch2.76 KBfmizzell
PASSED: [[SimpleTest]]: [MySQL] 57,947 pass(es).
[ View ]
#12 2002500-rename-exposed-form-validate-12.patch2.74 KBfmizzell
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 2002500-rename-exposed-form-validate-12.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]
#10 2002500-10.patch2.74 KBjibran
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 2002500-10.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]
#3 2002500-rename-exposed-form-validate-3.patch2.73 KBfmizzell
PASSED: [[SimpleTest]]: [MySQL] 55,696 pass(es).
[ View ]
#2 2002500-rename-exposed-form-validate.patch2.71 KBfmizzell
PASSED: [[SimpleTest]]: [MySQL] 55,703 pass(es).
[ View ]

Comments

fmizzell’s picture

Assigned:Unassigned» fmizzell
fmizzell’s picture

Status:Active» Needs review
StatusFileSize
new2.71 KB
PASSED: [[SimpleTest]]: [MySQL] 55,703 pass(es).
[ View ]
fmizzell’s picture

StatusFileSize
new2.73 KB
PASSED: [[SimpleTest]]: [MySQL] 55,696 pass(es).
[ View ]
fmizzell’s picture

the last patch adds the public modifiers to the methods

Status:Needs review» Needs work

The last submitted patch, 2002500-rename-exposed-form-validate-3.patch, failed testing.

oenie’s picture

The code looks good, but there seems to be something wrong with the BlockRenderOrderTest (very recently added)
I would mark this as blocked by http://drupal.org/node/1987952

oenie’s picture

Status:Needs work» Needs review
oenie’s picture

Status:Needs review» Reviewed & tested by the community

Looks good to me now !

alexpott’s picture

Status:Reviewed & tested by the community» Needs work

Needs a re-roll

curl http://drupal.org/files/2002500-rename-exposed-form-validate-3.patch | git a
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  2800  100  2800    0     0   7968      0 --:--:-- --:--:-- --:--:-- 16000
error: patch failed: core/modules/views/lib/Drupal/views/Plugin/views/pager/PagerPluginBase.php:241
error: core/modules/views/lib/Drupal/views/Plugin/views/pager/PagerPluginBase.php: patch does not apply
jibran’s picture

Status:Needs work» Needs review
StatusFileSize
new2.74 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 2002500-10.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

reroll

Status:Needs review» Needs work

The last submitted patch, 2002500-10.patch, failed testing.

fmizzell’s picture

Status:Needs work» Needs review
StatusFileSize
new2.74 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 2002500-rename-exposed-form-validate-12.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

Status:Needs review» Needs work
Issue tags:-Novice, -VDC

The last submitted patch, 2002500-rename-exposed-form-validate-12.patch, failed testing.

fmizzell’s picture

Status:Needs work» Needs review

Status:Needs review» Needs work
Issue tags:+Novice, +VDC

The last submitted patch, 2002500-rename-exposed-form-validate-12.patch, failed testing.

fmizzell’s picture

Status:Needs work» Needs review
StatusFileSize
new2.76 KB
PASSED: [[SimpleTest]]: [MySQL] 57,947 pass(es).
[ View ]

the patch applied just fine for me, but here goes a "reroll" anyways

aspilicious’s picture

Status:Needs review» Reviewed & tested by the community
alexpott’s picture

Status:Reviewed & tested by the community» Fixed

Committed d7ef279 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.