Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards

CommentFileSizeAuthor
#13 2002488-13.patch1.34 KBjibran
#6 drupal-camelcase-replace.2002488.6.patch1.34 KBbaldwinlouie
#3 drupal-camelcase-replace-2002488.3.patch1.33 KBbaldwinlouie
#2 drupal-camelcase-replace-2002488-7450378.patch1.33 KBbaldwinlouie

Comments

baldwinlouie’s picture

baldwinlouie commented
Assigned: Unassigned » baldwinlouie

taken by baldwinlouie and sillygwilo

baldwinlouie’s picture

baldwinlouie commented
Status: Active » Needs review
StatusFileSize
new drupal-camelcase-replace-2002488-7450378.patch1.33 KB

attaching patch

baldwinlouie’s picture

baldwinlouie commented
StatusFileSize
new drupal-camelcase-replace-2002488.3.patch1.33 KB

rerolling with access modifier

Status: Needs review » Needs work

The last submitted patch, drupal-camelcase-replace-2002488.3.patch, failed testing.

heddn’s picture

heddn
Primary language English
Location Illinois
commented

Failing tests. Please test and re-roll.

baldwinlouie’s picture

baldwinlouie commented
StatusFileSize
new drupal-camelcase-replace.2002488.6.patch1.34 KB

rerolling patch. This one passed testing on my local.

baldwinlouie’s picture

baldwinlouie commented
Status: Needs work » Needs review

changing status

aspilicious’s picture

aspilicious commented
Status: Needs review » Reviewed & tested by the community

Great!

somepal’s picture

somepal commented
Status: Reviewed & tested by the community » Patch (to be ported)

reviewed.we are good!

somepal’s picture

somepal commented

can apply #6 drupal-camelcase-replace.2002488.6.patch

aspilicious’s picture

aspilicious commented
Status: Patch (to be ported) » Reviewed & tested by the community
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Needs work

Needs reroll

curl https://drupal.org/files/drupal-camelcase-replace.2002488.6.patch | git a
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  1371  100  1371    0     0   1774      0 --:--:-- --:--:-- --:--:--  2285
error: patch failed: core/modules/views/lib/Drupal/views/Plugin/views/argument/ArgumentPluginBase.php:103
error: core/modules/views/lib/Drupal/views/Plugin/views/argument/ArgumentPluginBase.php: patch does not apply
error: patch failed: core/modules/views/lib/Drupal/views/ViewExecutable.php:899
error: core/modules/views/lib/Drupal/views/ViewExecutable.php: patch does not apply
jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Needs work » Needs review
StatusFileSize
new 2002488-13.patch1.34 KB

reroll

somepal’s picture

somepal commented
Status: Needs review » Reviewed & tested by the community

reviewed.gtg

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 92030a2 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.