Files: 
CommentFileSizeAuthor
#17 views-core-rename-ensure-table-2002484-16.patch15.22 KBhussainweb
PASSED: [[SimpleTest]]: [MySQL] 57,582 pass(es). View
#14 views-core-rename-ensure-table-2002484-14.patch15.22 KBSpartyDan
FAILED: [[SimpleTest]]: [MySQL] Invalid PHP syntax in core/modules/views/lib/Drupal/views/Plugin/views/query/Sql.php. View
#11 ensure_table_rename-2002484-11.patch16.55 KBheddn
PASSED: [[SimpleTest]]: [MySQL] 55,927 pass(es). View
#8 ensure_table_rename-2002484-3.patch8.24 KBbrennanmh
FAILED: [[SimpleTest]]: [MySQL] 55,773 pass(es), 3 fail(s), and 0 exception(s). View
#6 ensure_table_rename-2002484-2.patch8.23 KBbrennanmh
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git]. View
#1 ensure_table_rename-2002484.patch25.66 KBbrennanmh
FAILED: [[SimpleTest]]: [MySQL] 55,640 pass(es), 3 fail(s), and 0 exception(s). View

Comments

brennanmh’s picture

Status: Active » Needs review
FileSize
25.66 KB
FAILED: [[SimpleTest]]: [MySQL] 55,640 pass(es), 3 fail(s), and 0 exception(s). View

# modified: core/modules/views/lib/Drupal/views/ManyToOneHelper.php
# modified: core/modules/views/lib/Drupal/views/Plugin/views/HandlerBase.php
# modified: core/modules/views/lib/Drupal/views/Plugin/views/argument/ArgumentPluginBase.php
# modified: core/modules/views/lib/Drupal/views/Plugin/views/argument/ManyToOne.php
# modified: core/modules/views/lib/Drupal/views/Plugin/views/field/FieldPluginBase.php
# modified: core/modules/views/lib/Drupal/views/Plugin/views/query/Sql.php
# modified: core/modules/views/tests/views_test_data/lib/Drupal/views_test_data/Plugin/views/query/QueryTest.php
#

Status: Needs review » Needs work
Issue tags: -Novice, -VDC

The last submitted patch, ensure_table_rename-2002484.patch, failed testing.

connorwk’s picture

Status: Needs work » Needs review

#1: ensure_table_rename-2002484.patch queued for re-testing.

Status: Needs review » Needs work
Issue tags: +Novice, +VDC

The last submitted patch, ensure_table_rename-2002484.patch, failed testing.

oenie’s picture

index 1209901..5f2078b 100644
--- a/core/modules/views/lib/Drupal/views/ManyToOneHelper.php

@@ -508,7 +508,7 @@ function mark_table($table, $relationship, $alias) {
+  function ensureTable($table, $relationship = null, JoinPluginBase $join = null) {

Add public access modifier in front of the function to adher to the new OOP standards.

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/query/Sql.phpundefined
@@ -89,14 +89,14 @@ class Sql extends QueryPluginBase {
+  var $distinct = false;
...
+  var $has_aggregate = false;
...
+  var $get_count_optimized = null;

... and many more occurences

Every occurence of NULL, TRUE and FALSE should be uppercase. This patch changed all occurences to lowercase

brennanmh’s picture

Status: Needs work » Needs review
FileSize
8.23 KB
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git]. View

My bad. Should have stuck with vi instead of new install of phpStorm.

Anyway, this updated patch should have only the ensure_table() -> ensureTable() change.

oenie’s picture

Status: Needs review » Needs work
+++ b/core/modules/views/lib/Drupal/views/Plugin/views/query/Sql.phpundefined
@@ -508,7 +508,7 @@ function mark_table($table, $relationship, $alias) {
+  function ensureTable($table, $relationship = NULL, JoinPluginBase $join = NULL) {

Still missing that public access modifier though.

brennanmh’s picture

Status: Needs work » Needs review
FileSize
8.24 KB
FAILED: [[SimpleTest]]: [MySQL] 55,773 pass(es), 3 fail(s), and 0 exception(s). View

Third time's the charm? :)

Status: Needs review » Needs work

The last submitted patch, ensure_table_rename-2002484-3.patch, failed testing.

brennanmh’s picture

Assigned: Unassigned » brennanmh

Took ownership.

heddn’s picture

FileSize
16.55 KB
PASSED: [[SimpleTest]]: [MySQL] 55,927 pass(es). View

#3 won't apply any longer. Here's a reroll.

heddn’s picture

Status: Needs work » Needs review
dcam’s picture

Status: Needs review » Needs work
Issue tags: +Needs reroll

#11 doesn't apply any longer.

SpartyDan’s picture

Status: Needs work » Needs review
FileSize
15.22 KB
FAILED: [[SimpleTest]]: [MySQL] Invalid PHP syntax in core/modules/views/lib/Drupal/views/Plugin/views/query/Sql.php. View

re-roll

Status: Needs review » Needs work

The last submitted patch, views-core-rename-ensure-table-2002484-14.patch, failed testing.

drupee’s picture

Assigned: brennanmh » drupee
hussainweb’s picture

FileSize
15.22 KB
PASSED: [[SimpleTest]]: [MySQL] 57,582 pass(es). View

I have fixed the problem (and tested by installing Drupal and accessing views). I have also rerolled it against the latest tree.

dcam’s picture

Status: Needs work » Needs review

Setting status.

aspilicious’s picture

Status: Needs review » Reviewed & tested by the community
alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed 6345a5c and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.