Files: 
CommentFileSizeAuthor
#8 2002446-8.patch1.05 KBjibran
PASSED: [[SimpleTest]]: [MySQL] 56,802 pass(es).
[ View ]
#8 interdiff.txt650 bytesjibran
#6 2002446-rename-default-default-6.patch1.04 KBfmizzell
PASSED: [[SimpleTest]]: [MySQL] 55,772 pass(es).
[ View ]
#3 2002446-rename-default-default-3.patch1.03 KBfmizzell
FAILED: [[SimpleTest]]: [MySQL] 55,871 pass(es), 1 fail(s), and 0 exception(s).
[ View ]
#2 2002446-rename-default-default.patch1.02 KBfmizzell
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git].
[ View ]

Comments

fmizzell’s picture

Assigned:Unassigned» fmizzell
fmizzell’s picture

Status:Active» Needs review
StatusFileSize
new1.02 KB
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git].
[ View ]
fmizzell’s picture

StatusFileSize
new1.03 KB
FAILED: [[SimpleTest]]: [MySQL] 55,871 pass(es), 1 fail(s), and 0 exception(s).
[ View ]

someone made me aware of the need for 'public' in front of the method as part of our coding standards.

Status:Needs review» Needs work

The last submitted patch, 2002446-rename-default-default-3.patch, failed testing.

heddn’s picture

Failing tests. Please test and re-roll.

fmizzell’s picture

Status:Needs work» Needs review
StatusFileSize
new1.04 KB
PASSED: [[SimpleTest]]: [MySQL] 55,772 pass(es).
[ View ]
aspilicious’s picture

Status:Needs review» Needs work

Should be protected in stead of public

jibran’s picture

Status:Needs work» Needs review
StatusFileSize
new650 bytes
new1.05 KB
PASSED: [[SimpleTest]]: [MySQL] 56,802 pass(es).
[ View ]

Converted to protected.

dawehner’s picture

Status:Needs review» Reviewed & tested by the community

Nice!

alexpott’s picture

Status:Reviewed & tested by the community» Fixed

Committed cad23a5 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.