Rename Views method default_action() to defaultAction()

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/argument/ArgumentPluginBase.phpundefined
@@ -651,7 +651,7 @@ function default_summary_form(&$form, &$form_state) {
+  function defaultAction($info = NULL) {

Add protected access modifier in front of the functions to adher to the new OOP standards.

#4: rename-views-method-default-action-2002438-4.patch queued for re-testing.

rerolled patch

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/argument/ArgumentPluginBase.phpundefined
@@ -651,7 +651,7 @@ public function defaultSummaryForm(&$form, &$form_state) {
+  protected function defaultAction($info = NULL) {

+++ b/core/modules/views/lib/Drupal/views/ViewExecutable.phpundefined
@@ -911,7 +911,7 @@ protected function _buildArguments() {
+        $status = $argument->defaultAction();

This has to be public, as it's called from outside.

Thanks, I'll reroll again. Is there a simple way to tell this or do you just have to know what the module is doing to know?

Thanks

@theladebug: it's pretty straightforward:

If all calls you are seeing are on a $this instance (as was the case in the first patch), you can use protected.
If there are some calls where it's called on another instance, you have to use public.

So the reason why i suggested protected in comment #3, was because that patch had only $this->default_action() in its code. Using protected was fine there.

As it turns out, there was another call to the method that was missed in the first patch, as shown by dawehner #9 with the call $argument->defaultAction().

Because of that, you need to use public, because protected methods can only be called by an object itself (the $this->... construction).

@oenie - Thanks, I'm obviously a little rusty on my OOP (even though thats what all my "formal" training was - haha)

Committed 5c09348 and pushed to 8.x. Thanks!