Files: 
CommentFileSizeAuthor
#18 2002434-rename-create_view.patch3.2 KBsillygwailo
PASSED: [[SimpleTest]]: [MySQL] 56,068 pass(es). View
#15 2002434-rename-create_view.patch3.51 KBsillygwailo
PASSED: [[SimpleTest]]: [MySQL] 57,580 pass(es). View
#13 2002434-rename-create_view.patch3.56 KBsillygwailo
FAILED: [[SimpleTest]]: [MySQL] Setup environment: Test cancelled by admin prior to completion. View
#6 2002434-rename-create_view.patch3.57 KBsillygwailo
PASSED: [[SimpleTest]]: [MySQL] 57,427 pass(es). View
#2 2002434-rename-create_view.patch3.24 KBsillygwailo
PASSED: [[SimpleTest]]: [MySQL] 55,749 pass(es). View

Comments

sillygwailo’s picture

Assigned: Unassigned » sillygwailo

Taking this with baldwinlouie.

sillygwailo’s picture

FileSize
3.24 KB
PASSED: [[SimpleTest]]: [MySQL] 55,749 pass(es). View

Here's a patch.

sillygwailo’s picture

Status: Active » Needs review
dawehner’s picture

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/wizard/WizardPluginBase.phpundefined
@@ -1161,12 +1161,12 @@ public function validateView(array $form, array &$form_state) {
+   * Implements Drupal\views\Plugin\views\wizard\WizardInterface::createView().

The standard is {@inheritdoc}, just have a look at [#1354]

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/wizard/WizardPluginBase.phpundefined
@@ -1161,12 +1161,12 @@ public function validateView(array $form, array &$form_state) {
+      throw new WizardException('Attempted to createView with values that have not been validated.');

I guess if we already change this exception message something like "Attempted to create a view with values that have not been validated."

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/wizard/WizardInterface.phpundefined
@@ -55,6 +55,6 @@ public function validateView(array $form, array &$form_state);
+  function createView(array $form, array &$form_state);

This should be a public method

Status: Needs review » Needs work

The last submitted patch, 2002434-rename-create_view.patch, failed testing.

sillygwailo’s picture

Status: Needs work » Needs review
FileSize
3.57 KB
PASSED: [[SimpleTest]]: [MySQL] 57,427 pass(es). View

Re-rolled with the feedback.

Status: Needs review » Needs work
Issue tags: -Novice, -VDC

The last submitted patch, 2002434-rename-create_view.patch, failed testing.

dawehner’s picture

Status: Needs work » Needs review
Issue tags: +Novice, +VDC

#2: 2002434-rename-create_view.patch queued for re-testing.

dawehner’s picture

#6: 2002434-rename-create_view.patch queued for re-testing.

oenie’s picture

Status: Needs review » Reviewed & tested by the community

Looks good to me now.

alexpott’s picture

Status: Reviewed & tested by the community » Needs work

Needs a re-roll

 curl http://drupal.org/files/2002434-rename-create_view_0.patch | git a
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  3652  100  3652    0     0   9835      0 --:--:-- --:--:-- --:--:-- 18728
error: patch failed: core/modules/views/lib/Drupal/views/Plugin/views/wizard/WizardPluginBase.php:1161
error: core/modules/views/lib/Drupal/views/Plugin/views/wizard/WizardPluginBase.php: patch does not apply
sillygwailo’s picture

Status: Needs work » Needs review
FileSize
3.56 KB
FAILED: [[SimpleTest]]: [MySQL] Setup environment: Test cancelled by admin prior to completion. View

Re-rolled against a recent pull of 8.x (retrieve_validated_view in the original patch changed in core to retrieveValidatedView so it should match in the 'unchanged' lines now).

dawehner’s picture

Status: Needs review » Needs work
+++ b/core/modules/views/lib/Drupal/views/Plugin/views/wizard/WizardPluginBase.phpundefined
@@ -1161,12 +1161,12 @@ public function validateView(array $form, array &$form_state) {
+   * Implements Drupal\views\Plugin\views\wizard\WizardInterface::createView().
...
+  function createView(array $form, array &$form_state) {

public and @inheritdoc

sillygwailo’s picture

Status: Needs work » Needs review
FileSize
3.51 KB
PASSED: [[SimpleTest]]: [MySQL] 57,580 pass(es). View

Added, and re-rolled.

dawehner’s picture

Status: Needs review » Reviewed & tested by the community
+++ b/core/modules/views/lib/Drupal/views/Plugin/views/wizard/WizardPluginBase.phpundefined
@@ -198,7 +198,7 @@ public function getSorts() {
   /**
-   * Implements Drupal\views\Plugin\views\wizard\WizardInterface::build_form().
+   * {@inheritdoc}
    */
   function build_form(array $form, array &$form_state) {

Even I don't like this unrelated change ...

alexpott’s picture

Status: Reviewed & tested by the community » Needs work

If even @dawehner does not like the unrelated change displayed in #16... then lets not do it :)

sillygwailo’s picture

Status: Needs work » Needs review
FileSize
3.2 KB
PASSED: [[SimpleTest]]: [MySQL] 56,068 pass(es). View

Re-rolled with inheritDoc only for createView().

dawehner’s picture

Status: Needs review » Reviewed & tested by the community

Thank you!

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed 577949f and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.