Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards

CommentFileSizeAuthor
#3 2002420-check_access-2.patch3.32 KBoenie
#2 2002420-check_access-1.patch3.3 KBoenie

Comments

oenie’s picture

oenie commented
Assigned: Unassigned » oenie
oenie’s picture

oenie commented
Status: Active » Needs review
StatusFileSize
new 2002420-check_access-1.patch3.3 KB

This tag covers two separate check_access functions

- 1 in views/lib/Drupal/views/Plugin/views/argument_validator/ArgumentValidatorPluginBase.php
- 1 in views/lib/Drupal/views/Plugin/views/argument_default/ArgumentDefaultPluginBase.php

oenie’s picture

oenie commented
StatusFileSize
new 2002420-check_access-2.patch3.32 KB

Same patch, but added the forgotten access modifier for both functions.

Status: Needs review » Needs work
Issue tags: -Novice, -VDC

The last submitted patch, 2002420-check_access-2.patch, failed testing.

oenie’s picture

oenie commented
Status: Needs work » Needs review
Issue tags: +Novice, +VDC

#3: 2002420-check_access-2.patch queued for re-testing.

oenie’s picture

oenie commented
Status: Needs review » Reviewed & tested by the community

Looks good to me now !

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Needs review

@oenie it's a point of process not to rtbc your own patches.

oenie’s picture

oenie commented

@alexxpott: a bit too eager, hadn't even noticed that !
sorry :)

aspilicious’s picture

aspilicious commented

#3: 2002420-check_access-2.patch queued for re-testing.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

I can do that :)

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed fb03231 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.