Files: 
CommentFileSizeAuthor
#10 rename_views_method-2002412-10.patch1.97 KBmarlatt
PASSED: [[SimpleTest]]: [MySQL] 54,975 pass(es).
[ View ]
#8 2002412-8.patch1.97 KBmarlatt
FAILED: [[SimpleTest]]: [MySQL] 55,587 pass(es), 2 fail(s), and 0 exception(s).
[ View ]
#6 2002412-6.patch707 bytesmarlatt
PASSED: [[SimpleTest]]: [MySQL] 55,798 pass(es).
[ View ]
#2 2002412.patch700 bytesdavmorr
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git].
[ View ]

Comments

davmorr’s picture

Assigned:Unassigned» davmorr
davmorr’s picture

StatusFileSize
new700 bytes
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git].
[ View ]

Changed cache_set_expire() to cacheSetExpire()

davmorr’s picture

Status:Active» Needs review
oenie’s picture

Status:Needs review» Needs work
+++ b/core/modules/views/lib/Drupal/views/Plugin/views/cache/CachePluginBase.phpundefined
@@ -104,7 +104,7 @@ function cache_expire($type) { }
+  function cacheSetExpire($type) {

Add public access modifier in front of the function to adher to the new OOP standards.

oenie’s picture

double post - safely ignore

marlatt’s picture

Status:Needs work» Needs review
StatusFileSize
new707 bytes
PASSED: [[SimpleTest]]: [MySQL] 55,798 pass(es).
[ View ]

Added public to method. Patch looks good.

oenie’s picture

Status:Needs review» Needs work

I think you missed a few occurences of this method:

core/modules/views/lib/Drupal/views/Plugin/views/cache/CachePluginBase.php:128:

cache($this->table)->set($this->generateResultsKey(), $data, $this->cache_set_expire($type));

core/modules/views/lib/Drupal/views/Plugin/views/cache/CachePluginBase.php:133:

cache($this->table)->set($this->generateOutputKey(), $this->storage, $this->cache_set_expire($type));

core/modules/views/lib/Drupal/views/Plugin/views/cache/Time.php:121:

function cache_set_expire($type) {

In my previous comment i mentioned public as modifier, but since it seems to get invoked on $this, the access modifier can be protected instead of public.
Be sure to add it to the function declaration missed as well.

marlatt’s picture

Status:Needs work» Needs review
StatusFileSize
new1.97 KB
FAILED: [[SimpleTest]]: [MySQL] 55,587 pass(es), 2 fail(s), and 0 exception(s).
[ View ]

Re-rolled patch with corrections from #7

Status:Needs review» Needs work

The last submitted patch, 2002412-8.patch, failed testing.

marlatt’s picture

Status:Needs work» Needs review
StatusFileSize
new1.97 KB
PASSED: [[SimpleTest]]: [MySQL] 54,975 pass(es).
[ View ]

Unable to apply patch from #8 to create interdiff. Methods changed and method access set to protected.

Status:Needs review» Needs work
Issue tags:-Novice, -VDC

The last submitted patch, rename_views_method-2002412-10.patch, failed testing.

aspilicious’s picture

Status:Needs work» Needs review
Issue tags:+Novice, +VDC

#10: rename_views_method-2002412-10.patch queued for re-testing.

aspilicious’s picture

Status:Needs review» Reviewed & tested by the community
alexpott’s picture

Status:Reviewed & tested by the community» Fixed

Committed 8625dfc and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.