Rename Views method cache_set_expire() to cacheSetExpire()

Changed cache_set_expire() to cacheSetExpire()

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/cache/CachePluginBase.phpundefined
@@ -104,7 +104,7 @@ function cache_expire($type) { }
+  function cacheSetExpire($type) {

Add public access modifier in front of the function to adher to the new OOP standards.

double post - safely ignore

Added public to method. Patch looks good.

I think you missed a few occurences of this method:

core/modules/views/lib/Drupal/views/Plugin/views/cache/CachePluginBase.php:128:

cache($this->table)->set($this->generateResultsKey(), $data, $this->cache_set_expire($type));

core/modules/views/lib/Drupal/views/Plugin/views/cache/CachePluginBase.php:133:

cache($this->table)->set($this->generateOutputKey(), $this->storage, $this->cache_set_expire($type));

core/modules/views/lib/Drupal/views/Plugin/views/cache/Time.php:121:

function cache_set_expire($type) {

In my previous comment i mentioned public as modifier, but since it seems to get invoked on $this, the access modifier can be protected instead of public.
Be sure to add it to the function declaration missed as well.

Re-rolled patch with corrections from #7

Unable to apply patch from #8 to create interdiff. Methods changed and method access set to protected.

#10: rename_views_method-2002412-10.patch queued for re-testing.

Committed 8625dfc and pushed to 8.x. Thanks!