Files: 
CommentFileSizeAuthor
#14 7449722-rename-method-cache-get-11.patch2.24 KBfmizzell
PASSED: [[SimpleTest]]: [MySQL] 57,834 pass(es).
[ View ]
#9 7449722-rename-method-cache-get-9.patch2.23 KBfmizzell
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 7449722-rename-method-cache-get-9.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]
#4 7449722-rename-method-cache-get-4.patch2.23 KBfmizzell
PASSED: [[SimpleTest]]: [MySQL] 57,967 pass(es).
[ View ]
#2 7449722-rename-method-cache-get.patch2.22 KBfmizzell
PASSED: [[SimpleTest]]: [MySQL] 55,732 pass(es).
[ View ]

Comments

fmizzell’s picture

Assigned:Unassigned» fmizzell
fmizzell’s picture

Status:Active» Needs review
StatusFileSize
new2.22 KB
PASSED: [[SimpleTest]]: [MySQL] 55,732 pass(es).
[ View ]
oenie’s picture

Status:Needs review» Needs work
+++ b/core/modules/views/lib/Drupal/views/Plugin/views/cache/CachePluginBase.phpundefined
@@ -141,7 +141,7 @@ function cache_set($type) {
+  function cacheGet($type) {

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/cache/None.phpundefined
@@ -31,11 +31,11 @@ public function summaryTitle() {
+  function cacheGet($type) {

Add public access modifier in front of the functions to adher to the new OOP standards.

fmizzell’s picture

Status:Needs work» Needs review
StatusFileSize
new2.23 KB
PASSED: [[SimpleTest]]: [MySQL] 57,967 pass(es).
[ View ]

Status:Needs review» Needs work

The last submitted patch, 7449722-rename-method-cache-get-4.patch, failed testing.

heddn’s picture

Failing tests. Please test and re-roll.

oenie’s picture

Status:Needs work» Needs review
oenie’s picture

Status:Needs review» Needs work

I really hate to do this ... but unfortunately we need a reroll, the patch doesn't apply anymore.

fmizzell’s picture

Status:Needs work» Needs review
StatusFileSize
new2.23 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 7449722-rename-method-cache-get-9.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]
aspilicious’s picture

Status:Needs review» Reviewed & tested by the community
catch’s picture

Issue tags:-Novice, -VDC

Status:Reviewed & tested by the community» Needs work
Issue tags:+Novice, +VDC

The last submitted patch, 7449722-rename-method-cache-get-9.patch, failed testing.

oenie’s picture

Issue tags:+Needs reroll

Unfortunately we need a reroll, the patch doesn't apply anymore.

fmizzell’s picture

Status:Needs work» Needs review
Issue tags:-Needs reroll
StatusFileSize
new2.24 KB
PASSED: [[SimpleTest]]: [MySQL] 57,834 pass(es).
[ View ]
aspilicious’s picture

Status:Needs review» Reviewed & tested by the community
alexpott’s picture

Status:Reviewed & tested by the community» Fixed

Committed fc827a8 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.