Rename Views method cache_expire() to cacheExpire() [#2002396]

Comment	File	Size	Author
#5	drupal_rename_cache_expire-2002396-5.patch	1.58 KB	nathangervais
#1	cache_expire_rename-2002396.patch	2.84 KB	brennanmh

Comment #1

brennanmh commented 24 May 2013 at 18:02

Status:

Active

» Needs review

Status	File	Size
new	cache_expire_rename-2002396.patch	2.84 KB

changed cache_expire to cacheExpire in CachePluginBase.php and Time.php

Log in or register to post comments

Comment #2

munizjor commented 24 May 2013 at 18:55

Status:

Needs review

» Needs work

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/cache/CachePluginBase.phpundefined
@@ -142,11 +142,11 @@ function cache_set($type) {
-        return FALSE;

true and false have to be uppercase.

Log in or register to post comments

Comment #3

craychee commented 24 May 2013 at 19:04

Assigned:

Unassigned

» craychee

Log in or register to post comments

Comment #4

oenie commented 24 May 2013 at 21:59

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/cache/CachePluginBase.phpundefined
@@ -93,7 +93,7 @@ public function summaryTitle() {
+  function cacheExpire($type) { }

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/cache/Time.phpundefined
@@ -107,7 +107,7 @@ function get_lifespan($type) {
+  function cacheExpire($type) {

Add protected access modifier in front of the functions to adher to the new OOP standards.