Files: 
CommentFileSizeAuthor
#5 drupal_rename_cache_expire-2002396-5.patch1.58 KBnathangervais
PASSED: [[SimpleTest]]: [MySQL] 55,948 pass(es).
[ View ]
#1 cache_expire_rename-2002396.patch2.84 KBbrennanmh
FAILED: [[SimpleTest]]: [MySQL] 55,871 pass(es), 1 fail(s), and 0 exception(s).
[ View ]

Comments

brennanmh’s picture

Status:Active» Needs review
StatusFileSize
new2.84 KB
FAILED: [[SimpleTest]]: [MySQL] 55,871 pass(es), 1 fail(s), and 0 exception(s).
[ View ]

changed cache_expire to cacheExpire in CachePluginBase.php and Time.php

munizjor’s picture

Status:Needs review» Needs work
+++ b/core/modules/views/lib/Drupal/views/Plugin/views/cache/CachePluginBase.phpundefined
@@ -142,11 +142,11 @@ function cache_set($type) {
-        return FALSE;

true and false have to be uppercase.

craychee’s picture

Assigned:Unassigned» craychee
oenie’s picture

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/cache/CachePluginBase.phpundefined
@@ -93,7 +93,7 @@ public function summaryTitle() {
+  function cacheExpire($type) { }

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/cache/Time.phpundefined
@@ -107,7 +107,7 @@ function get_lifespan($type) {
+  function cacheExpire($type) {

Add protected access modifier in front of the functions to adher to the new OOP standards.

nathangervais’s picture

Assigned:craychee» nathangervais
Status:Needs work» Needs review
StatusFileSize
new1.58 KB
PASSED: [[SimpleTest]]: [MySQL] 55,948 pass(es).
[ View ]

Rerolled patch using protectect access modifier and renaming the function to camelCase.

aspilicious’s picture

Status:Needs review» Reviewed & tested by the community

Looking good

alexpott’s picture

Status:Reviewed & tested by the community» Fixed

Committed 486b8b8 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.