Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
views.module
Priority:
Normal
Category:
Task
Assigned:
Issue tags:
Reporter:
Created:
24 May 2013 at 03:23 UTC
Updated:
29 Jul 2014 at 22:23 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
x.algorithm commentedI'll work on this
Comment #2
x.algorithm commentedI made changes requested.
I edited 4 files.
I created a view utilising articles.
My format was table. I made a sort on title.
It rendered successfully so I believe it should be ready
Please review
Comment #3
oenie commentedAdd public access modifier in front of the functions to adher to the new OOP standards.
Comment #4
nathangervais commentedRerolled Patch to only include buildSortPost with public modifier.
Comment #6
aspilicious commentedIndentation is incorrect :s
Comment #7
chrisguindon commentedReroll of #4 + with 2 spaces before public function buildSortPost() { }.
Comment #9
aspilicious commentedLook at the first oatches, you're missing some changes
Comment #10
suhel.rangnekar commentedCovered all build_sort_post().
Comment #11
oenie commentedLooks good to me now.
Comment #12
alexpottCommitted c3ac610 and pushed to 8.x. Thanks!