Files: 
CommentFileSizeAuthor
#10 Rename_Views_method_build_sort_post_to_buildSortPost.patch5.14 KBsuhel.rangnekar
PASSED: [[SimpleTest]]: [MySQL] 57,292 pass(es). View
#7 views_rename_build_sort_post-2002390-7.patch3.07 KBchrisguindon
FAILED: [[SimpleTest]]: [MySQL] 57,340 pass(es), 17 fail(s), and 0 exception(s). View
#4 views_rename_build_sort_post-2002390-4.patch3.07 KBnathangervais
FAILED: [[SimpleTest]]: [MySQL] 55,867 pass(es), 4 fail(s), and 0 exception(s). View
#2 drupal-rename_views_method_build_sort_post_2.patch10.04 KBx.algorithm
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git]. View

Comments

x.algorithm’s picture

Assigned: Unassigned » x.algorithm

I'll work on this

x.algorithm’s picture

Status: Active » Needs review
FileSize
10.04 KB
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git]. View

I made changes requested.

I edited 4 files.

I created a view utilising articles.
My format was table. I made a sort on title.
It rendered successfully so I believe it should be ready

Please review

oenie’s picture

Status: Needs review » Needs work
+++ b/core/modules/views/lib/Drupal/views/Plugin/views/argument/ArgumentPluginBase.phpundefined
@@ -960,7 +960,7 @@ public function validateArgument($arg) {
+  function validateArgument($arg) {

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/argument_validator/ArgumentValidatorPluginBase.phpundefined
@@ -80,7 +80,7 @@ function check_access(&$form, $option_name) {
+  function validateArgument($arg) { return TRUE; }

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/argument_validator/None.phpundefined
@@ -22,7 +22,7 @@
+  function validateArgument($argument) {

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/argument_validator/Numeric.phpundefined
@@ -22,7 +22,7 @@
+  function validateArgument($argument) {

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/argument_validator/Php.phpundefined
@@ -49,7 +49,7 @@ public function access() {
+  function validateArgument($argument) {

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/style/StylePluginBase.phpundefined
@@ -379,7 +379,7 @@ function build_sort() { return TRUE; }
+  function buildSortPost() { }

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/style/Table.phpundefined
@@ -121,7 +121,7 @@ function build_sort() {
+  function buildSortPost() {

Add public access modifier in front of the functions to adher to the new OOP standards.

nathangervais’s picture

Status: Needs work » Needs review
FileSize
3.07 KB
FAILED: [[SimpleTest]]: [MySQL] 55,867 pass(es), 4 fail(s), and 0 exception(s). View

Rerolled Patch to only include buildSortPost with public modifier.

Status: Needs review » Needs work

The last submitted patch, views_rename_build_sort_post-2002390-4.patch, failed testing.

aspilicious’s picture

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/style/StylePluginBase.phpundefined
@@ -391,7 +391,7 @@ function build_sort() { return TRUE; }
+ public function buildSortPost() { }

Indentation is incorrect :s

chrisguindon’s picture

Status: Needs work » Needs review
FileSize
3.07 KB
FAILED: [[SimpleTest]]: [MySQL] 57,340 pass(es), 17 fail(s), and 0 exception(s). View

Reroll of #4 + with 2 spaces before public function buildSortPost() { }.

Status: Needs review » Needs work

The last submitted patch, views_rename_build_sort_post-2002390-7.patch, failed testing.

aspilicious’s picture

Look at the first oatches, you're missing some changes

suhel.rangnekar’s picture

Assigned: x.algorithm » suhel.rangnekar
Status: Needs work » Needs review
FileSize
5.14 KB
PASSED: [[SimpleTest]]: [MySQL] 57,292 pass(es). View

Covered all build_sort_post().

oenie’s picture

Status: Needs review » Reviewed & tested by the community

Looks good to me now.

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed c3ac610 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.