Rename Views method build_sort_post() to buildSortPost() [#2002390]

Comment	File	Size	Author
#10	Rename_Views_method_build_sort_post_to_buildSortPost.patch	5.14 KB	suhel.rangnekar
#7	views_rename_build_sort_post-2002390-7.patch	3.07 KB	chrisguindon
#4	views_rename_build_sort_post-2002390-4.patch	3.07 KB	nathangervais
#2	drupal-rename_views_method_build_sort_post_2.patch	10.04 KB	x.algorithm

Comment #1

x.algorithm commented 24 May 2013 at 18:38

Assigned:

Unassigned

» x.algorithm

I'll work on this

Log in or register to post comments

Comment #2

x.algorithm commented 24 May 2013 at 19:35

Status:

Active

» Needs review

Status	File	Size
new	drupal-rename_views_method_build_sort_post_2.patch	10.04 KB

I made changes requested.

I edited 4 files.

I created a view utilising articles.
My format was table. I made a sort on title.
It rendered successfully so I believe it should be ready

Please review

Log in or register to post comments

Comment #3

oenie commented 24 May 2013 at 21:57

Status:

Needs review

» Needs work

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/argument/ArgumentPluginBase.phpundefined
@@ -960,7 +960,7 @@ public function validateArgument($arg) {
+  function validateArgument($arg) {

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/argument_validator/ArgumentValidatorPluginBase.phpundefined
@@ -80,7 +80,7 @@ function check_access(&$form, $option_name) {
+  function validateArgument($arg) { return TRUE; }

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/argument_validator/None.phpundefined
@@ -22,7 +22,7 @@
+  function validateArgument($argument) {

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/argument_validator/Numeric.phpundefined
@@ -22,7 +22,7 @@
+  function validateArgument($argument) {

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/argument_validator/Php.phpundefined
@@ -49,7 +49,7 @@ public function access() {
+  function validateArgument($argument) {

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/style/StylePluginBase.phpundefined
@@ -379,7 +379,7 @@ function build_sort() { return TRUE; }
+  function buildSortPost() { }

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/style/Table.phpundefined
@@ -121,7 +121,7 @@ function build_sort() {
+  function buildSortPost() {

Add public access modifier in front of the functions to adher to the new OOP standards.

Log in or register to post comments

Comment #4

nathangervais commented 2 June 2013 at 14:27

Status:

Needs work

» Needs review

Status	File	Size
new	views_rename_build_sort_post-2002390-4.patch	3.07 KB

Rerolled Patch to only include buildSortPost with public modifier.

Log in or register to post comments

Comment #5

3 June 2013 at 04:13

Status:

Needs review

» Needs work

The last submitted patch, views_rename_build_sort_post-2002390-4.patch, failed testing.

Log in or register to post comments

Comment #6

aspilicious commented 12 June 2013 at 20:00

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/style/StylePluginBase.phpundefined
@@ -391,7 +391,7 @@ function build_sort() { return TRUE; }
+ public function buildSortPost() { }

Indentation is incorrect :s