Files: 
CommentFileSizeAuthor
#5 views-core-blockDisplayOptions-2002366-05.patch3.61 KBSpartyDan
PASSED: [[SimpleTest]]: [MySQL] 57,605 pass(es). View
#2 2002366-2-rename_blockDisplayOptions.patch3.52 KBGung Wang
PASSED: [[SimpleTest]]: [MySQL] 55,761 pass(es). View

Comments

Gung Wang’s picture

Assigned: Unassigned » Gung Wang

I take it.

Gung Wang’s picture

Status: Active » Needs review
FileSize
3.52 KB
PASSED: [[SimpleTest]]: [MySQL] 55,761 pass(es). View

Uploaded the patch.

elvis2’s picture

Should the access modifier on this function be public?

heddn’s picture

If the method is only used internally i.e. $this->{foo}, then I'd recommend protected. Otherwise, go with public as it needs to be usable by folks outside the class is apart of the public API.

SpartyDan’s picture

FileSize
3.61 KB
PASSED: [[SimpleTest]]: [MySQL] 57,605 pass(es). View
+++ b/core/modules/comment/lib/Drupal/comment/Plugin/views/wizard/Comment.php
@@ -113,8 +113,8 @@ protected function page_display_options(array $form, array &$form_state) {
   /**
    * Overrides Drupal\views\Plugin\views\wizard\WizardPluginBase::page_display_options().
    */

Corrected error in documentation page_display_options should be block_display_options which is updated by this patch to be blockDisplayOptions

Updates from patch in comment #2 are also included in this patch.

aspilicious’s picture

Status: Needs review » Reviewed & tested by the community

Should be ok if it comes back green

elvis2’s picture

Status: Reviewed & tested by the community » Needs review
aspilicious’s picture

Status: Needs review » Reviewed & tested by the community
alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed cb1e2df and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.