Files: 
CommentFileSizeAuthor
#5 views-rename_attach_to-2002362-5.patch1.35 KBJeroenT
PASSED: [[SimpleTest]]: [MySQL] 56,954 pass(es).
[ View ]
#3 views-2002362-attachTo-3.patch1.81 KBzschmid
FAILED: [[SimpleTest]]: [MySQL] 57,282 pass(es), 387 fail(s), and 234 exception(s).
[ View ]
#2 2002362-2-rename_attachTo.patch1.34 KBGung Wang
Test request sent.
[ View ]

Comments

Gung Wang’s picture

Assigned:Unassigned» Gung Wang

I take it.

Gung Wang’s picture

Status:Active» Needs review
StatusFileSize
new1.34 KB
Test request sent.
[ View ]
zschmid’s picture

StatusFileSize
new1.81 KB
FAILED: [[SimpleTest]]: [MySQL] 57,282 pass(es), 387 fail(s), and 234 exception(s).
[ View ]

Access modifier should be protected. adding an updated patch

Status:Needs review» Needs work

The last submitted patch, views-2002362-attachTo-3.patch, failed testing.

JeroenT’s picture

Status:Needs work» Needs review
StatusFileSize
new1.35 KB
PASSED: [[SimpleTest]]: [MySQL] 56,954 pass(es).
[ View ]
aspilicious’s picture

Status:Needs review» Reviewed & tested by the community

Done =)

alexpott’s picture

Status:Reviewed & tested by the community» Fixed

Committed 31586f7 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.