Files: 
CommentFileSizeAuthor
#17 2002348-rename-advanced_render.patch35.61 KBsillygwailo
PASSED: [[SimpleTest]]: [MySQL] 55,347 pass(es). View
#8 drupal-camelcase-2002348.8.patch33.65 KBbaldwinlouie
FAILED: [[SimpleTest]]: [MySQL] Drupal installation failed. View
#5 drupal-camelcase-2002348-v2.patch33.64 KBbaldwinlouie
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git]. View
#2 drupal-camelcase-removal-2002348-7449008.patch36.31 KBbaldwinlouie
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch drupal-camelcase-removal-2002348-7449008.patch. Unable to apply patch. See the log in the details link for more information. View

Comments

baldwinlouie’s picture

Assigned: Unassigned » baldwinlouie

claimed by baldwinlouie and sillygwailo

baldwinlouie’s picture

FileSize
36.31 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch drupal-camelcase-removal-2002348-7449008.patch. Unable to apply patch. See the log in the details link for more information. View

attaching the patch

baldwinlouie’s picture

Status: Active » Needs review

setting to needs review

Status: Needs review » Needs work

The last submitted patch, drupal-camelcase-removal-2002348-7449008.patch, failed testing.

baldwinlouie’s picture

Status: Needs work » Needs review
FileSize
33.64 KB
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git]. View

rerolled the patch

oenie’s picture

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/field/FieldPluginBase.phpundefined
@@ -1108,7 +1108,7 @@ function render($values) {
+  function advancedRender($values) {

Add public access modifier in front of the function to adher to the new OOP standards.

oenie’s picture

Status: Needs review » Needs work
+++ b/core/modules/views/lib/Drupal/views/Plugin/views/field/FieldPluginBase.phpundefined
@@ -1108,7 +1108,7 @@ function render($values) {
+  function advancedRender($values) {

Add public access modifier in front of the function to adher to the new OOP standards.

baldwinlouie’s picture

FileSize
33.65 KB
FAILED: [[SimpleTest]]: [MySQL] Drupal installation failed. View

rerolled with access modifier

baldwinlouie’s picture

Status: Needs work » Needs review

changing back to needs review

oenie’s picture

Status: Needs review » Reviewed & tested by the community

Looks fine by me now.

alexpott’s picture

Status: Reviewed & tested by the community » Needs work

A new test has been added that uses the advanced_render method... Drupal\file\Tests\Views\ExtensionViewsFieldTest

heddn’s picture

Status: Needs work » Needs review
Issue tags: -Novice, -VDC

#8: drupal-camelcase-2002348.8.patch queued for re-testing.

Status: Needs review » Needs work
Issue tags: +Novice, +VDC

The last submitted patch, drupal-camelcase-2002348.8.patch, failed testing.

heddn’s picture

Status: Needs work » Needs review
FileSize
36.78 KB
PASSED: [[SimpleTest]]: [MySQL] 57,298 pass(es). View

Let's try actually updating the test first... before we run testbot.

aspilicious’s picture

Status: Needs review » Reviewed & tested by the community

Looks ok

alexpott’s picture

Status: Reviewed & tested by the community » Needs work

Patch no longer applies...

curl https://drupal.org/files/drupal-camelcase-2002348.13.patch | git a
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 37667  100 37667    0     0  22519      0  0:00:01  0:00:01 --:--:-- 25128
error: patch failed: core/modules/views/lib/Drupal/views/Plugin/views/field/FieldPluginBase.php:1108
error: core/modules/views/lib/Drupal/views/Plugin/views/field/FieldPluginBase.php: patch does not apply
sillygwailo’s picture

Status: Needs work » Needs review
FileSize
35.61 KB
PASSED: [[SimpleTest]]: [MySQL] 55,347 pass(es). View

Re-rolled.

aspilicious’s picture

Status: Needs review » Reviewed & tested by the community
webchick’s picture

Title: Rename Views method advanced_render() to advancedRender() » Change notice: Rename Views method advanced_render() to advancedRender()
Project: Drupal core » Views
Version: 8.x-dev » 8.x-3.x-dev
Component: views.module » Code
Status: Reviewed & tested by the community » Active
Issue tags: +Needs change record

Committed and pushed to 8.x. Thanks!

Moving to Views for the change notice.

xjm’s picture

Title: Change notice: Rename Views method advanced_render() to advancedRender() » Rename Views method advanced_render() to advancedRender()
Project: Views » Drupal core
Version: 8.x-3.x-dev » 8.x-dev
Component: Code » views.module
Assigned: baldwinlouie » Unassigned
Status: Active » Fixed
Issue tags: -Needs change record

Automatically closed -- issue fixed for 2 weeks with no activity.