Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
views.module
Priority:
Normal
Category:
Task
Assigned:
Issue tags:
Reporter:
Created:
24 May 2013 at 03:09 UTC
Updated:
29 Jul 2014 at 22:23 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
seantwalshWorking on this as part of the Portland2013 getting involved with core sprint.
Comment #2
seantwalshReplaced 7 instances of adjust_join with adjustJoin.
Comment #3
seantwalshOoooooooooooops!
Comment #4
marlatt commentedReviewed methods, added public to function.
Comment #5
farfanfelipe commentedComment #6
farfanfelipe commentedI added some more replacement that were not done in the complete views.module
Comment #7
marlatt commentedReviewed methods and functions.
Comment #8
attiks commentedFYI: This patch contains a lot of other changes, not described in the issue summary, leaving at RTBC, but adding just so core committers see this.
Comment #9
farfanfelipe commentedAdd Public to methods that have not visibility assigned is part of the new Drupal standards
Comment #10
alexpottThis patch should only touch the method adjust_join() and convert it to adjustJoin() - all other changes are out-of-scope and will conflict with related changes.
Comment #11
heddnRe-rolled. Marked method as protected rather than public since it only seems to be used internally.
Comment #13
nathangervais commented#11: drupal-viewsRename_adjust_join-2002346-11.patch queued for re-testing.
Comment #14
aspilicious commentedComment #15
alexpottNeeds a reroll
Comment #16
jibranreroll
Comment #18
heddnRerolled.
Comment #19
aspilicious commentedComment #20
alexpottCommitted 863a9bd and pushed to 8.x. Thanks!