Files: 
CommentFileSizeAuthor
#8 drupal-viewsRename-add_where_expression-2002344-8.patch15.76 KBheddn
PASSED: [[SimpleTest]]: [MySQL] 57,555 pass(es). View
#6 drupal-viewsRename-add_where_expression-2002344-6.patch14.43 KBheddn
FAILED: [[SimpleTest]]: [MySQL] 56,423 pass(es), 2 fail(s), and 0 exception(s). View
#4 2002344-4-rename-add_where_expression.patch14.46 KBelvis2
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 2002344-4-rename-add_where_expression.patch. Unable to apply patch. See the log in the details link for more information. View
#2 2002344-2-rename-add_where_expression.patch14.34 KBelvis2
PASSED: [[SimpleTest]]: [MySQL] 55,904 pass(es). View

Comments

elvis2’s picture

Assigned: Unassigned » elvis2
elvis2’s picture

Status: Active » Needs review
FileSize
14.34 KB
PASSED: [[SimpleTest]]: [MySQL] 55,904 pass(es). View
oenie’s picture

Status: Needs review » Needs work

This one as well, good work !
Unfortunately we need a reroll, the patch doesn't apply anymore.

elvis2’s picture

Status: Needs work » Needs review
FileSize
14.46 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 2002344-4-rename-add_where_expression.patch. Unable to apply patch. See the log in the details link for more information. View

Re-rolled

Status: Needs review » Needs work

The last submitted patch, 2002344-4-rename-add_where_expression.patch, failed testing.

heddn’s picture

Status: Needs work » Needs review
FileSize
14.43 KB
FAILED: [[SimpleTest]]: [MySQL] 56,423 pass(es), 2 fail(s), and 0 exception(s). View

Previous patch wouldn't apply. Let's try this one.

Status: Needs review » Needs work

The last submitted patch, drupal-viewsRename-add_where_expression-2002344-6.patch, failed testing.

heddn’s picture

Status: Needs work » Needs review
FileSize
15.76 KB
PASSED: [[SimpleTest]]: [MySQL] 57,555 pass(es). View

Seems I missed a rename in core/modules/views/lib/Drupal/views/Plugin/views/filter/Date.php

Let's see how we fair this time.

aspilicious’s picture

Status: Needs review » Reviewed & tested by the community
alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed fc1bd6f and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.