Files: 
CommentFileSizeAuthor
#10 2002340-10-rename-add_where.patch21.62 KBjibran
PASSED: [[SimpleTest]]: [MySQL] 56,683 pass(es).
[ View ]
#7 2002340-7-rename-add_where.patch21.47 KBelvis2
PASSED: [[SimpleTest]]: [MySQL] 56,023 pass(es).
[ View ]
#5 2002340-5-rename-add_where.patch21.39 KBelvis2
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 2002340-5-rename-add_where.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]
#4 2002340-4-rename-add_where.patch21.45 KBelvis2
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 2002340-4-rename-add_where.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]
#2 2002340-2-rename-add_where.patch21.47 KBelvis2
PASSED: [[SimpleTest]]: [MySQL] 55,835 pass(es).
[ View ]

Comments

elvis2’s picture

Assigned:Unassigned» elvis2
elvis2’s picture

Status:Active» Needs review
StatusFileSize
new21.47 KB
PASSED: [[SimpleTest]]: [MySQL] 55,835 pass(es).
[ View ]
oenie’s picture

Status:Needs review» Needs work

That's some nice work.
Unfortunately we need a reroll, the patch doesn't apply anymore.

elvis2’s picture

Status:Needs work» Needs review
StatusFileSize
new21.45 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 2002340-4-rename-add_where.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

Re-rolled

elvis2’s picture

StatusFileSize
new21.39 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 2002340-5-rename-add_where.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

Oops, I found a typo and fixed it...

Status:Needs review» Needs work

The last submitted patch, 2002340-5-rename-add_where.patch, failed testing.

elvis2’s picture

Status:Needs work» Needs review
StatusFileSize
new21.47 KB
PASSED: [[SimpleTest]]: [MySQL] 56,023 pass(es).
[ View ]

Re-rolled based on most recent pull of 8.x branch.

aspilicious’s picture

Status:Needs review» Reviewed & tested by the community
alexpott’s picture

Status:Reviewed & tested by the community» Needs work

Needs reroll

curl https://drupal.org/files/2002340-7-rename-add_where.patch | git a
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 21983  100 21983    0     0  17736      0  0:00:01  0:00:01 --:--:-- 20602
error: patch failed: core/modules/views/lib/Drupal/views/Plugin/views/filter/Numeric.php:253
error: core/modules/views/lib/Drupal/views/Plugin/views/filter/Numeric.php: patch does not apply
error: patch failed: core/modules/views/lib/Drupal/views/Plugin/views/filter/String.php:298
error: core/modules/views/lib/Drupal/views/Plugin/views/filter/String.php: patch does not apply
jibran’s picture

Status:Needs work» Needs review
StatusFileSize
new21.62 KB
PASSED: [[SimpleTest]]: [MySQL] 56,683 pass(es).
[ View ]

re-roll

aspilicious’s picture

Status:Needs review» Reviewed & tested by the community
alexpott’s picture

Status:Reviewed & tested by the community» Fixed

Committed 167810f and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.