Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards

CommentFileSizeAuthor
#10 2002340-10-rename-add_where.patch21.62 KBjibran
#7 2002340-7-rename-add_where.patch21.47 KBelvis2
#5 2002340-5-rename-add_where.patch21.39 KBelvis2
#4 2002340-4-rename-add_where.patch21.45 KBelvis2
#2 2002340-2-rename-add_where.patch21.47 KBelvis2

Comments

elvis2’s picture

elvis2 commented
Assigned: Unassigned » elvis2
elvis2’s picture

elvis2 commented
Status: Active » Needs review
StatusFileSize
new 2002340-2-rename-add_where.patch21.47 KB
oenie’s picture

oenie commented
Status: Needs review » Needs work

That's some nice work.
Unfortunately we need a reroll, the patch doesn't apply anymore.

elvis2’s picture

elvis2 commented
Status: Needs work » Needs review
StatusFileSize
new 2002340-4-rename-add_where.patch21.45 KB

Re-rolled

elvis2’s picture

elvis2 commented
StatusFileSize
new 2002340-5-rename-add_where.patch21.39 KB

Oops, I found a typo and fixed it...

Status: Needs review » Needs work

The last submitted patch, 2002340-5-rename-add_where.patch, failed testing.

elvis2’s picture

elvis2 commented
Status: Needs work » Needs review
StatusFileSize
new 2002340-7-rename-add_where.patch21.47 KB

Re-rolled based on most recent pull of 8.x branch.

aspilicious’s picture

aspilicious commented
Status: Needs review » Reviewed & tested by the community
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Needs work

Needs reroll

curl https://drupal.org/files/2002340-7-rename-add_where.patch | git a
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 21983  100 21983    0     0  17736      0  0:00:01  0:00:01 --:--:-- 20602
error: patch failed: core/modules/views/lib/Drupal/views/Plugin/views/filter/Numeric.php:253
error: core/modules/views/lib/Drupal/views/Plugin/views/filter/Numeric.php: patch does not apply
error: patch failed: core/modules/views/lib/Drupal/views/Plugin/views/filter/String.php:298
error: core/modules/views/lib/Drupal/views/Plugin/views/filter/String.php: patch does not apply
jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Needs work » Needs review
StatusFileSize
new 2002340-10-rename-add_where.patch21.62 KB

re-roll

aspilicious’s picture

aspilicious commented
Status: Needs review » Reviewed & tested by the community
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 167810f and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.