Files: 
CommentFileSizeAuthor
#9 2002280-9-rename-add_signature.patch1.93 KBelvis2
PASSED: [[SimpleTest]]: [MySQL] 55,826 pass(es). View
#4 2002280-4.patch1.78 KBconnorwk
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git]. View
#2 2002280-2-rename-add_signature.patch1.92 KBelvis2
PASSED: [[SimpleTest]]: [MySQL] 55,686 pass(es). View

Comments

elvis2’s picture

Assigned: Unassigned » elvis2
elvis2’s picture

Status: Active » Needs review
FileSize
1.92 KB
PASSED: [[SimpleTest]]: [MySQL] 55,686 pass(es). View
valthebald’s picture

Status: Needs review » Needs work

Extra space in function get_aggregation_info() comment, otherwise looks fine

connorwk’s picture

Status: Needs work » Needs review
FileSize
1.78 KB
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git]. View

I removed the extra spaces in-front of the comment.

valthebald’s picture

Status: Needs review » Reviewed & tested by the community

Looks fine for me, no more occurrences of add_signature() in core folder

oenie’s picture

Status: Reviewed & tested by the community » Needs work
+++ b/core/modules/views/lib/Drupal/views/Plugin/views/query/QueryPluginBase.phpundefined
@@ -79,7 +79,7 @@ function execute(ViewExecutable $view) {  }
+  function addSignature(ViewExecutable $view) { }

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/query/Sql.phpundefined
@@ -1643,7 +1643,7 @@ function load_entities(&$results) {
+  function addSignature(ViewExecutable $view) {

Add public access modifier in front of the function to adher to the new OOP standards.

valthebald’s picture

@oenie, what was the reason to change issue status from RTBC?

oenie’s picture

@valtthebald: as mentioned in my small review, we have to make sure that all methods are supplied with an access modifier.
See the META issue, comment #28.
Since we're doing these patches, we might as well make sure they get done as good as we can.

elvis2’s picture

Status: Needs work » Needs review
FileSize
1.93 KB
PASSED: [[SimpleTest]]: [MySQL] 55,826 pass(es). View

I added access modifier.

Status: Needs review » Needs work
Issue tags: -Novice, -VDC

The last submitted patch, 2002280-9-rename-add_signature.patch, failed testing.

elvis2’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 2002280-9-rename-add_signature.patch, failed testing.

elvis2’s picture

Status: Needs work » Needs review
Issue tags: +Novice, +VDC
oenie’s picture

Status: Needs review » Reviewed & tested by the community

Looks good to me now !

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed b880d8f and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.