Files: 
CommentFileSizeAuthor
#9 2002274-9-rename-add_relationship.patch8.33 KBelvis2
PASSED: [[SimpleTest]]: [MySQL] 55,000 pass(es). View
#8 2002274-8-rename-add_relationship.patch103.56 KBelvis2
FAILED: [[SimpleTest]]: [MySQL] 56,180 pass(es), 0 fail(s), and 1 exception(s). View
#5 2002274-5-rename-add_relationship.patch8.53 KBelvis2
PASSED: [[SimpleTest]]: [MySQL] 55,692 pass(es). View
#2 2002274-1-rename-add_relationship.patch8.52 KBelvis2
PASSED: [[SimpleTest]]: [MySQL] 55,920 pass(es). View

Comments

elvis2’s picture

Assigned: Unassigned » elvis2
elvis2’s picture

Status: Active » Needs review
FileSize
8.52 KB
PASSED: [[SimpleTest]]: [MySQL] 55,920 pass(es). View
valthebald’s picture

Status: Needs review » Needs work

Missing replacement of QueryPluginBase::add_signature in core/modules/views/lib/Drupal/views/Plugin/views/query/QueryPluginBase.php

oenie’s picture

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/query/Sql.phpundefined
@@ -290,7 +290,7 @@ public function submitOptionsForm(&$form, &$form_state) {
+  function addRelationship($alias, JoinPluginBase $join, $base, $link_point = NULL) {

Add public access modifier in front of the method to adher to the new OOP standards.

elvis2’s picture

Status: Needs work » Needs review
FileSize
8.53 KB
PASSED: [[SimpleTest]]: [MySQL] 55,692 pass(es). View

Added access modifier.

oenie’s picture

Status: Needs review » Reviewed & tested by the community

Looks fine by me now !

alexpott’s picture

Status: Reviewed & tested by the community » Needs work
+++ b/core/modules/comment/lib/Drupal/comment/Plugin/views/field/NcsLastCommentName.phpundefined
@@ -40,7 +40,7 @@ public function query() {
-//    $this->user_table = $this->query->add_relationship(NULL, $join, 'users', $this->relationship);
+//    $this->user_table = $this->query->addRelationship(NULL, $join, 'users', $this->relationship);

+++ b/core/modules/comment/lib/Drupal/comment/Plugin/views/sort/NcsLastCommentName.phpundefined
@@ -33,7 +33,7 @@ public function query() {
-//    $this->user_table = $this->query->add_relationship(NULL, $join, 'users', $this->relationship);
+//    $this->user_table = $this->query->addRelationship(NULL, $join, 'users', $this->relationship);

I think we should be removing the commented out lines of code. That's why we have a SCM.

elvis2’s picture

Status: Needs work » Needs review
FileSize
103.56 KB
FAILED: [[SimpleTest]]: [MySQL] 56,180 pass(es), 0 fail(s), and 1 exception(s). View

Re-rolled removing commented out lines and renamed add_relationship().

elvis2’s picture

FileSize
8.33 KB
PASSED: [[SimpleTest]]: [MySQL] 55,000 pass(es). View

Arggg, sorry about the last patch, I rolled it without "git rest --hard"...

Re-roll of #8.

Status: Needs review » Needs work
Issue tags: -Novice, -VDC

The last submitted patch, 2002274-9-rename-add_relationship.patch, failed testing.

Cottser’s picture

Status: Needs work » Needs review
Issue tags: +Novice, +VDC
aspilicious’s picture

Status: Needs review » Reviewed & tested by the community
alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed 18e0327 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.