Closed (works as designed)
Project:
Mailchimp
Version:
7.x-2.x-dev
Component:
General
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
24 May 2013 at 00:35 UTC
Updated:
3 Jun 2013 at 21:35 UTC
the mailchimp module (http://drupal.org/project/mailchimp) requires a separate step to install the MailChimp API library
Download the MailChimp API library and extract it to the libraries folder, so that the API library can be found at libraries/mailchimp/MCAPI.class.php
from: http://drupal.org/documentation/modules/mailchimp
Is there any way to make this happen so one can test this module?
Comments
Comment #1
patrickd commentedUnfortunately simplytest.me can't guess what libraries the modules require and therefore we have to rely on the module maintainers to provide a .make file to download the libraries automatically.
Moving this to the MailChimp issue queue as feature request.
For more information please have a look at the Q&A section on http://simplytest.me/questions-and-answers#developers
Comment #2
gcbThis file exists as "mailchimp.make.example" in the module directory.
Comment #3
patrickd commentedIt makes no sense to call it ".example" in my eyes - example for what?
This file shouldn't be an example, it should be THE make-file to use for downloading the library.
Would you mind following the general practice and rename it to .make?
Comment #4
levelos commented@patrickd, using module_name.make.example is a general best practice. Feel free to skip the "uhms" and bold text next time if you want to have a productive conversation about an issue.
Comment #5
patrickd commentedUsing formatted text was not intended to hurt anyone, I kept my words very kind.
Can you show where this is used as a general best practice? I could not find any other module making use of this.
It also seems very counterproductive to me as eg. drush will only automatically resolve dependencies of contributed modules when it can find a properly named .make file or a .drush.inc integration.
Comment #6
patrickd commentedI edited the "offending" comment to be more friendly (?). Sorry for the misunderstanding, but when I'm sure about something I tend to write that way.
I'm currently advertising that practice for contrib modules on simplytest.me's documentation and if this is wrong I should really stop doing it.
So if anyone knows a documentation page on drupal.org or some blog entry where this practice is described and recommended please let me know before I keep telling everyone that naming it ".make" is a good practice (because I already did and until this moment I've never doubted it - because it seemed logical to me).
Or is there some unspoken reason we handle .make files on profiles different than in modules and themes?
Comment #7
patrickd commentedOkay #1103872: Change name of ckeditor.make to ckeditor.make.example for drush make module, Issue summary explains the problem
I personally don't like the solution much and find it these naming practices rather confusing, but I get the point.
To fix this problem I'll try to support both, ".make" and ".make.example" files.
Thanks for pointing me to this problem, forgive me being a smart ass.
Comment #8
levelos commented@patrickd, thanks for the great follow up, we're all good.