Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
user interface text
Priority:
Minor
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
24 May 2013 at 00:05 UTC
Updated:
29 Jul 2014 at 22:22 UTC
Jump to comment: Most recent, Most recent file


Comments
Comment #1
rbomhof commentedCapitalized the operation links for comments and taxonomy terms in this patch. See screenshots for updated text!
Comment #4
rbomhof commentednot sure why this one failed testing. when i apply this patch directly, i see the updated links. perhaps related to #1452896: PHP notice in clickLink if link does not exist?
Comment #5
okish commentedComment #6
okish commentedSo the test code itself hadn't been modified to reflect the change in name to the links.
What is weird to me is that that only resolves one of the issues. the other tests that are failing are on lines 313 & 314 in function testTermInterface() in file:
/core/modules/taxonomy/lib/Drupal/taxonomy/Tests/TermTest.php
The lines that are failing:
i'm still trying to figure out why these would be failing, but thought i would throw this out there in case anyone has any insights to share before i figure it out as i'm not too familiar with SimpleTest and didn't write the testing script.
Comment #7
tompagabor commentedHere is the updated version of the patch. Let's see the testing result.. Also change operations links on watchdog, Imagestyle admin, Link field.
Comment #9
tompagabor commentedSomebody please help to fix the test, because it's wants to click the first Edit link
There was an "Edit" end an "edit" link.
But now, there is two "Edit" link on the page.
Another patch is included, where i fix the another simpletest error, and capitalize two more operations link.
Comment #10
tompagabor commentedThe wrong test is:
/core/modules/taxonomy/lib/Drupal/taxonomy/Tests/TermTest.php
line 316.
And the first Edit link is for taxonomy, and the second is for Term, and we need the term edit link.
Comment #11
pakmanlhHere I attached the patch modifying the test.
Comment #13
lauriiiComment #15
floretan commentedOne of the taxonomy term tests was checking the link label and failing because of that.
Comment #16
saltednutChecked this manually against both UI's and it looks good. Patch applies cleanly and tests are passing since #15.
Comment #18
webchickNice clean-up!
Committed and pushed to 8.x. Thanks!