Comments

rbomhof’s picture

Status: Active » Needs review
StatusFileSize
new1.82 KB
new25.75 KB
new25.69 KB
new23.84 KB
new23.52 KB

Capitalized the operation links for comments and taxonomy terms in this patch. See screenshots for updated text!

Status: Needs review » Needs work
Issue tags: -Novice

rbomhof’s picture

not sure why this one failed testing. when i apply this patch directly, i see the updated links. perhaps related to #1452896: PHP notice in clickLink if link does not exist?

okish’s picture

Assigned: Unassigned » okish
okish’s picture

So the test code itself hadn't been modified to reflect the change in name to the links.

What is weird to me is that that only resolves one of the issues. the other tests that are failing are on lines 313 & 314 in function testTermInterface() in file:

/core/modules/taxonomy/lib/Drupal/taxonomy/Tests/TermTest.php

The lines that are failing:

    $this->assertRaw($edit['name'], 'The randomly generated term name is present.');
    $this->assertText($edit['description[value]'], 'The randomly generated term description is present.');

i'm still trying to figure out why these would be failing, but thought i would throw this out there in case anyone has any insights to share before i figure it out as i'm not too familiar with SimpleTest and didn't write the testing script.

tompagabor’s picture

Issue summary: View changes
Status: Needs work » Needs review
StatusFileSize
new22.85 KB

Here is the updated version of the patch. Let's see the testing result.. Also change operations links on watchdog, Imagestyle admin, Link field.

Status: Needs review » Needs work

The last submitted patch, 7: 2002246-capitalize-7.patch, failed testing.

tompagabor’s picture

Assigned: okish » Unassigned
StatusFileSize
new22.95 KB

Somebody please help to fix the test, because it's wants to click the first Edit link
There was an "Edit" end an "edit" link.
But now, there is two "Edit" link on the page.

Another patch is included, where i fix the another simpletest error, and capitalize two more operations link.

tompagabor’s picture

The wrong test is:
/core/modules/taxonomy/lib/Drupal/taxonomy/Tests/TermTest.php
line 316.

    // Test edit link as accessed from Taxonomy administration pages.
    // Because Simpletest creates its own database when running tests, we know
    // the first edit link found on the listing page is to our term.
    $this->clickLink(t('Edit'));

And the first Edit link is for taxonomy, and the second is for Term, and we need the term edit link.

pakmanlh’s picture

Status: Needs work » Needs review
StatusFileSize
new22.95 KB
new840 bytes

Here I attached the patch modifying the test.

Status: Needs review » Needs work

The last submitted patch, 11: 2002246-capitalize-11.patch, failed testing.

lauriii’s picture

Status: Needs work » Needs review
StatusFileSize
new761 bytes
new23.24 KB

Status: Needs review » Needs work

The last submitted patch, 13: 2002246-capitalize-13.patch, failed testing.

floretan’s picture

Status: Needs work » Needs review
StatusFileSize
new23.73 KB
new806 bytes

One of the taxonomy term tests was checking the link label and failing because of that.

saltednut’s picture

Status: Needs review » Reviewed & tested by the community

Checked this manually against both UI's and it looks good. Patch applies cleanly and tests are passing since #15.

The last submitted patch, 9: 2002246-capitalize-9.patch, failed testing.

webchick’s picture

Status: Reviewed & tested by the community » Fixed

Nice clean-up!

Committed and pushed to 8.x. Thanks!

  • Commit cd94c10 on 8.x by webchick:
    Issue #2002246 by tompagabor, floretan, lauriii, pakmanlh, rbomhof |...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.