devel.mail.inc doesn't provide a label for the Subject header in emails written to tmp/devel-mails [#2002030]

I ran into this while testing #1560012: Port per-user issue notification email functionality to D7. It's minor, but annoying. If you use devel.mail.inc, you see stuff like this:

From: "admin (D7 Project)" <admin@example.com>
Date: Thu, 23 May 2013 15:23:17 -0400
...
To: admin@example.com
[Task] Yet another new title
Issue status update for:
http://localhost/d7project/node/30
Update issue:
http://localhost/d7project/node/30/edit

It should really look like this:

From: "admin (D7 Project)" <admin@example.com>
Date: Thu, 23 May 2013 15:23:17 -0400
...
To: admin@example.com
Subject: [Task] Yet another new title

Issue status update for:
http://localhost/d7project/node/30
Update issue:
http://localhost/d7project/node/30/edit

At first, I thought my email generation code was broken, but upon closer inspection, it was just how devel.mail.inc is writing this stuff to disk. :/

Comment	File	Size	Author
#6	2002030-6.devel-mail-d8.patch	1.19 KB	dww
#6
#6	2002030-6.devel-mail-d7.patch	1.01 KB	dww
#6
#3	2002030-3.devel-mail-d7.patch	939 bytes	dww
#3
#1	2002030-1.devel-mail-d7.patch	589 bytes	dww
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

dww

we/he/they

CreditAttribution: dww commented 23 May 2013 at 19:33

Status:

Active

» Needs review

File	Size
2002030-1.devel-mail-d7.patch	589 bytes

Any objections? I can forward/back port to other branches if not.

Thanks,
-Derek

Comment #2

24 May 2013 at 07:24

Status:

Needs review

» Needs work

The last submitted patch, 2002030-1.devel-mail-d7.patch, failed testing.

Comment #3

dww

we/he/they

CreditAttribution: dww commented 24 May 2013 at 11:52

Status:

Needs work

» Needs review

File	Size
2002030-3.devel-mail-d7.patch	939 bytes

Heh. ;) Fixed the test.

Comment #4

moshe weitzman CreditAttribution: moshe weitzman commented 24 May 2013 at 22:33

Status:

Needs review

» Reviewed & tested by the community

Looks fine to me. Will commit soon if nobody objects.

Comment #5

salvis

he/his

CreditAttribution: salvis commented 31 May 2013 at 07:36

Status:

Reviewed & tested by the community

» Needs work

+++ b/devel.mail.inc
@@ -27,7 +27,8 @@ class DevelMailLog extends DefaultMailSystem {
+    $output .= t('Subject: ') . $message['subject'] . $line_endings;
+    $output .= '-----' . $line_endings;

"Subject" is a mail header and should not be translated. And it should be followed by an empty line, not dashes.

Yes, D8 first. :-)