Use Symfony Request for system module

atchijov & johnbickar working on this.

Per atchijov, unit tests for these changes will fail until https://drupal.org/node/1998696 is resolved.

Also per atchijov:

• changes to OverrideServerVariablesUnitTest.php depends on drupal_override_server_variables() in core/includes/bootstrap.inc
• changes to TableSortExtenderUnitTest.php depends on tablesort_init() in core/includes/tablesort.inc
• core/modules/system/lib/Drupal/system/Tests/Database/SelectPagerDefaultTest.php does not do proper setup/teardown - poisoning $_GET
• core/modules/system/lib/Drupal/system/Tests/Form/TriggeringElementTest.php does not use any superglobals
• core/modules/system/tests/modules/menu_test/menu_test.module does not use any superglobals
• core/modules/system/tests/modules/session_test/session_test.module does not use any superglobals

#3: drupal-use_symfony_request_for_system_module-1999434-3.patch queued for re-testing.


+++ b/core/modules/system/lib/Drupal/system/Tests/Bootstrap/OverrideServerVariablesUnitTest.phpundefined
@@ -25,10 +25,13 @@ public static function getInfo() {
+ $request = \Drupal::request();
+ $server = $request->server;
+ $script_name = $server->get('SCRIPT_NAME');

+++ b/core/modules/system/lib/Drupal/system/Tests/Common/RenderTest.phpundefined
@@ -139,8 +139,9 @@ function testDrupalRenderSorting() {
+ $server = \Drupal::request()->server;
+ $request_method = $server->get('REQUEST_METHOD');

On a pure unit test the Drupal request will not be available here. We should use Request::createFormGlobals(); instead

#3: drupal-use_symfony_request_for_system_module-1999434-3.patch queued for re-testing.

+++ b/core/modules/system/system.admin.incundefined
@@ -260,8 +260,10 @@ function system_themes_admin_form_submit($form, &$form_state) {
+  if (isset($theme) && isset($token) && drupal_valid_token($token, 'system-theme-operation-link')) {

These will always be set. I think you need !empty() now.

+++ b/core/modules/system/system.api.phpundefined
@@ -1766,9 +1766,8 @@ function hook_template_preprocess_default_variables_alter(&$variables) {
+  $request = Drupal::request();
+  return $request->query->get('theme');

Can this be combined into one line?

This issue was RTBC and passing tests on July 1, the beginning of API freeze.

Committed 09d7b81 and pushed to 8.x. Thanks!