Remove comment_save() and comment_delete()/comment_delete_multiple() in favor of $comment->save()/$comment->delete()

Made a start on this, attached patch!

What's happening to the hooks for comment_save and comment_delete?

Replaced comment_save/comment_delete/comment_delete_multiple($ids) with $comment->save()/$comment->delete()/entity_delete_multiple('comment', $ids). Removed this functions and updated comments.

Will be done today during Code Sprint UA.

Patch attached.

simple patch, looks like all documentation updated
If bot happy - i`m happy too
RTBC after green bot

fixed.

Good thing we have a bot, I missed that one.

+++ b/core/modules/system/lib/Drupal/system/Tests/Theme/EntityFilteringThemeTest.php
@@ -113,7 +113,7 @@ function setUp() {
-    comment_save($this->comment);
+    $comment->save();

Should be $this->comment->save();

yeah, but I have changed this line in the #14 patch.

Oops, that was a crosspost. Patch looks good.

+1 rtbc, nice clean-up for #731724: Convert comment settings into a field to make them work with CMI and non-node entities

#14: comment-remove_comment_save_delete-1999328-14.patch queued for re-testing.

reroll.

Proper merge, actions now plugins

Committed/pushed to 8.x thanks!

I missed that this was still testing when committing, if 8.x comes back green that's OK but otherwise will need to revert...