trying to save a translation for views like here: admin/structure/views/view/frontpage/translate/edit/de does only work for "Administrative description" and "Human readable name" but not for a Display Setting like the Title of a Display.
There is no error thrown, it's just not saved. Does not work for all Views, not only the Frontpage

Files: 
CommentFileSizeAuthor
#12 1999192-config-translastion-views-12.patch3.79 KBSchnitzel
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 1999192-config-translastion-views-12.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]
#5 1999192-config-translastion-views-5.patch3.86 KBSchnitzel
PASSED: [[SimpleTest]]: [MySQL] 244 pass(es).
[ View ]
#5 1999192-config-translastion-views-5-testonly.patch2.98 KBSchnitzel
FAILED: [[SimpleTest]]: [MySQL] 234 pass(es), 10 fail(s), and 0 exception(s).
[ View ]
#3 1999192-config-translastion-views-tests-only.patch3.08 KBSchnitzel
FAILED: [[SimpleTest]]: [MySQL] Failed to run tests: failed to login to test site.
[ View ]
#3 1999192-config-translastion-views-3.patch3.95 KBSchnitzel
FAILED: [[SimpleTest]]: [MySQL] Failed to run tests: failed to login to test site.
[ View ]

Comments

vijaycs85’s picture

Ok, it looks like we are loosing the structure of data in language specific file. in base file(views.view.frontpage.yml) it is display.page_1.display_title where as in language specific file (locale.config.fr.views.view.frontpage.yml) it is saved as page_1.display_title.

Schnitzel’s picture

Issue tags:+Needs tests

this should be covered by tests

Schnitzel’s picture

Status:Active» Needs review
StatusFileSize
new3.95 KB
FAILED: [[SimpleTest]]: [MySQL] Failed to run tests: failed to login to test site.
[ View ]
new3.08 KB
FAILED: [[SimpleTest]]: [MySQL] Failed to run tests: failed to login to test site.
[ View ]

found the issue, also added some tests

Status:Needs review» Needs work

The last submitted patch, 1999192-config-translastion-views-3.patch, failed testing.

Schnitzel’s picture

Status:Needs work» Needs review
StatusFileSize
new2.98 KB
FAILED: [[SimpleTest]]: [MySQL] 234 pass(es), 10 fail(s), and 0 exception(s).
[ View ]
new3.86 KB
PASSED: [[SimpleTest]]: [MySQL] 244 pass(es).
[ View ]

so this had a small issue, fixed now

Status:Needs review» Needs work
Issue tags:-Needs tests

The last submitted patch, 1999192-config-translastion-views-5-testonly.patch, failed testing.

Schnitzel’s picture

Status:Needs work» Needs review
Schnitzel’s picture

Schnitzel’s picture

Status:Needs review» Needs work
Issue tags:+Needs tests

The last submitted patch, 1999192-config-translastion-views-5-testonly.patch, failed testing.

Gábor Hojtsy’s picture

Except the indentation, it looks great.

Schnitzel’s picture

Status:Needs work» Needs review
StatusFileSize
new3.79 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 1999192-config-translastion-views-12.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

new full patch with correct white space

Gábor Hojtsy’s picture

Status:Needs review» Fixed

Great, thanks, committed! Also fixed the remaining minor whitespace problem on the way! :)

Automatically closed -- issue fixed for 2 weeks with no activity.