CSS/JS directory is not created or writable if enabled with Drush

Code in question: advagg_requirements()

    list($css_path, $js_path) = advagg_get_root_files_dir();

    // What should be in the array.
    // $css_path[0] = public://advagg_css
    // $js_path[0] = public://advagg_js

    // Make sure directories are writable.
    if (!file_prepare_directory($css_path[0], FILE_CREATE_DIRECTORY)) {
      $requirements['advagg_css_path'] = array(
        'title' => $t('Adv CSS/JS Agg - CSS Path'),
        'severity' => REQUIREMENT_ERROR,
        'value' => $t('CSS directory is not created or writable.'),
        'description' => $t('%path is not setup correctly.', array('%path' => $css_path)),
      );
    }
    if (!file_prepare_directory($js_path[0], FILE_CREATE_DIRECTORY)) {
      $requirements['advagg_js_path'] = array(
        'title' => $t('Adv CSS/JS Agg - JS Path'),
        'severity' => REQUIREMENT_ERROR,
        'value' => $t('JS directory is not created or writable.'),
        'description' => $t('%path is not setup correctly.', array('%path' => $js_path)),
      );
    }

This is a simple check to make sure that file_prepare_directory() returns TRUE. It's very similar code to what we have in core drupal_build_css_cache() ($csspath variable), drupal_build_js_cache() ($jspath variable).

Could I get the output of this on your system?

print_r(advagg_get_root_files_dir());

Are you getting these errors in watchdog? "The file permissions could not be set on %uri." from drupal_chmod()

So I would have to run chown() & chgrp() on hook_install/enable.

Some combination of stat() & posix_getpwuid() (if function exists) on public:// and then set the dir ownership from there.

ps I'll be on vacation till the 27th (not at drupalcon) so feel free to create a patch for this.

I've committed this patch. Let me know if it doesn't fix the drush issue.

Also committed this

I hate to be a bother, but which of these patches do I apply? I tried the first one and got after drush cc all:
Drush command terminated abnormally due to an unrecoverable error.
Error: syntax error, unexpected '$stat_public' (T_VARIABLE) in /home/***/public_html/sites/all/modules/advagg/advagg.install, line 57
Parse error: syntax error, unexpected '$stat_public' (T_VARIABLE) in /home/***/public_html/sites/all/modules/advagg/advagg.install on line 57

Doing the second patch gives:
File to patch: advagg.install
patching file advagg.install
Hunk #1 succeeded at 52 (offset 40 lines).
Hunk #2 FAILED at 460.
1 out of 2 hunks FAILED -- saving rejects to file advagg.install.rej

I rarely implement patches so I am not sure what is fixed and what is not.

The post-installation fix mentioned above required moving the file permissions to the webserver. I am on a VPS and am not wanting to do this. My file permissions are:

drwxrwxr-x 2 user user 4.0K Aug 19 06:13 advagg_css/
drwxrwxr-x 2 user user 4.0K Aug 19 06:13 advagg_js/

Sorry for the confusion, but what is the actual file permissions needed for this module so this can be fixed?

Thanks!

As a follow up to this I wanted to let folks know how I solved this. My unix permissions were fine. The problem was that my php.ini had a list of disabled_functions that was causing things not to be written to the directory.

@tetmo
The patches have been committed, thus you do not need to apply them unless you have an older version of AdvAgg; upgrade if that is the case :)

I can add in a check to see if a php function has been disabled before trying to use it. Do you remember what functions were disabled in your php.ini?

rename

I must say that rename an odd function to disable. I'll add it to the installation requirements check.

Created this issue #2070197: Check that needed php functions are not disabled. Closing this issue.

I disable everything that is not needed and this is the first time this function has been needed. But to your point, most site administrators will probably not encounter this issue.