After upgrading from 7.x-1.0-beta3 to 7.x-1.0-beta4, I started getting several PHP undefined index notices when displaying a View block that is set up to show the "city" from an address field. For example:

Notice: Undefined index: name_line in _addressfield_render_address() (line 223 of /sites/all/modules/addressfield/addressfield.module)

Other undefined indices include country, postal code, premise, and thoroughfare. I.e., all the keys except "city" are undefined.

In comparing the code at line 223 in addressfield.module, it looks like there used to be a critical isset() check in beta3 that was removed in beta4.

-        $child['#children'] = isset($address[$key]) ? check_plain($address[$key]) : '';
+        $child['#children'] = check_plain($address[$key]);

Any reason it was removed? Can it be put back?

CommentFileSizeAuthor
#8 addressfield-1997572-suppress_field_warnings.patch1.06 KBxurizaemon
#7 addressfield-1997572-7.patch467 bytesplach

Comments

rszrama’s picture

rszrama commented
Version: 7.x-1.0-beta4 » 7.x-1.x-dev
Status: Active » Fixed

Looking at that line in beta3, it appears to me you added that isset() yourself: http://drupalcode.org/project/addressfield.git/blob/fc024d23ffe7791127c2...

That leads me to believe there's some other customization in your site that is causing it to attempt to render an address using a format that doesn't have corresponding address elements. Whatever the issue, I can make it more defensive.

Commit: http://drupalcode.org/project/addressfield.git/commitdiff/57883f9

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

boabjohn’s picture

boabjohn commented
Status: Closed (fixed) » Active

Hi guys,
Not a coder, but we are getting exactly the same notices and I've definitely not touched the isset()
We are on 7.x-1.0-beta4
This started when I added a View with aggregation to get a count of nodes, summarised on country.
Happy to export the view for further inspection...here's asample of the notices (appears to be one for every addressfield component):

Notice: Undefined index: thoroughfare in _addressfield_render_address() (line 223 of /home/cadb/htdocs/drupal/sites/all/modules/addressfield/addressfield.module).
Notice: Undefined index: premise in _addressfield_render_address() (line 223 of /home/cadb/htdocs/drupal/sites/all/modules/addressfield/addressfield.module).
Notice: Undefined index: locality in _addressfield_render_address() (line 223 of /home/cadb/htdocs/drupal/sites/all/modules/addressfield/addressfield.module).
Notice: Undefined index: administrative_area in _addressfield_render_address() (line 223 of /home/cadb/htdocs/drupal/sites/all/modules/addressfield/addressfield.module).
Notice: Undefined index: postal_code in _addressfield_render_address() (line 223 of /home/cadb/htdocs/drupal/sites/all/modules/addressfield/addressfield.module).
Notice: Undefined index: thoroughfare in _addressfield_render_address() (line 223 of /home/cadb/htdocs/drupal/sites/all/modules/addressfield/addressfield.module).
rszrama’s picture

rszrama commented
Status: Active » Closed (fixed)

Note that this was fixed after the beta4 release, hence the issue still showing for you. : )

Update to -dev and it'll be gone.

boabjohn’s picture

boabjohn commented

Thanks and sorry for missing the clue!

Anonymous’s picture

Anonymous (not verified) commented
Issue summary: View changes
Status: Closed (fixed) » Active

Hello, I am sorry to reopen this issue but it is the exact same problem with the exact same line number and code. Tested on beta5 and dev releases.

I had to expand on the patch. I was getting errors for "administrative_area" (it seems sometimes it is set to "--") and also for "dependent_locality" (one entry was set to blank or a space or something). I'm not sure if this breaks anything, hopefully not... but at least now my reports don't show errors at the top of the page.

252      //if (!empty($child['#render_option_value']) && isset($child['#options'][$address[$key]])) {
253      if (!empty($child['#render_option_value']) && $key != 'administrative_area' && $key != 'dependent_locality' && isset($child['#options'][$address[$key]])) {
plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented
Status: Active » Needs review
StatusFileSize
new addressfield-1997572-7.patch467 bytes

I'm seeing notices with the current -dev too. The attached patch gets rid of them here.

xurizaemon’s picture

xurizaemon
he/him
Location Ōtepoti, Aotearoa 🏝
commented
StatusFileSize
new addressfield-1997572-suppress_field_warnings.patch1.06 KB

I had to add back the original isset as well. This bug may require testing with "incomplete" (or just not US-formatted) addresses, which would explain why it doesn't appear for some people? FWIW I was seeing the issue on the default Commerce Reports page.

Ryan, 57883f9 doesn't fix it because $address[$key] is unset, and is used in line 252 (even in an isset, if it's not the subject of the isset).

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Status: Needs review » Reviewed & tested by the community

@xurizaemon's patch worked and exact use case: Commerce Reports. The Views aggregate and use addressfield for charts. I tested on Customer Profiles created using devel_generate and had notices arise.

Tested on beta5: projects[addressfield][version] = 1.0-beta5

millionleaves’s picture

millionleaves commented

Xurizaemon's patch worked for me in the same use case.

  • bojanz committed 48702fc on 7.x-1.x authored by xurizaemon 
    Issue #1997572 by plach, xurizaemon: Undefined index in...
bojanz’s picture

bojanz commented
Status: Reviewed & tested by the community » Fixed

Committed, thanks.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.