Hi,

Running a code review with the coder module on comment.admin.inc produces the following warning:

Line 191: in confirm_form, use $form_state['redirect'] instead of return (remember to change function prototype to use &$form_state)

         return 'admin/content/comment';

More information on D6 form API and $form_state['redirect'] can be found at http://drupal.org/node/144132#form-state

Cheers,
Stella

CommentFileSizeAuthor
#1 $form_state['redirect'].patch691 bytesPancho
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Pancho’s picture

Pancho
Location UTC+2 🇪🇺 EU
CreditAttribution: Pancho commented
Version: 6.0-beta4 » 6.x-dev
Status: Active » Needs review
FileSize
$form_state['redirect'].patch691 bytes

Fixed this. Also removed unneeded "return;" in comment_confirm_delete_submit(). Would be cool if you tested both...

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Needs review » Fixed

Good catch. Committed to CVS HEAD. Thanks.

Anonymous’s picture

(not verified) CreditAttribution: commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.