A few changes to floats and margins on the search form and block broke compatibility with placing the block in the navbar. This patch fixes that.

CommentFileSizeAuthor
#7 bootstrap-search-block-broken-1993968-7.patch11.87 KBmarkhalliwell
#7 interdiff.txt777 bytesmarkhalliwell
#3 bootstrap-search-block-broken-1993968-2.patch11.07 KBmarkhalliwell
#2 search-block-navbar-right-7408102-2.patch1.57 KBandregriffin
#1 search-block-navbar-right.patch779 bytesandregriffin
search-block-navbar.patch778 bytesandregriffin

Comments

andregriffin’s picture

andregriffin commented
StatusFileSize
new search-block-navbar-right.patch779 bytes

Also, I don't know if I'm the only one that thinks this, but I quite like the search form floated to the right in the navbar.

andregriffin’s picture

andregriffin commented
StatusFileSize
new search-block-navbar-right-7408102-2.patch1.57 KB

However, in the float-right option, it would make sense to print the navigation "region" after both primary AND secondary links.

markhalliwell’s picture

markhalliwell
Primary language English
commented
StatusFileSize
new bootstrap-search-block-broken-1993968-2.patch11.07 KB

Actually, I disagree about the tpl change. Users might want to put stuff in between the two. Simply float the block to the right will suffice (and I agree, looks better). Went ahead and consolidated the selectors too. PS: anytime we alter the overrides.less file, we need to recompile the overrides.css file as well.

andregriffin’s picture

andregriffin commented
Title: Search block broken in navbar. » Search block broken

Also, the .element-invisible class doesn't seem to be doing the trick on the submit button anymore, causing horizontal scrollbars when placed in the secondary sidebar at various window widths. I've not yet figured out a proper fix for this.

markhalliwell’s picture

markhalliwell
Primary language English
commented

That's an entirely different issue (although sounds similar to #1870076: Fixing horizontal scroll bar on iPhone). It also seems to only pertain to web-kit browsers. Created issue: #1994044: .element-invisible causes mobile to scroll horizontally

andregriffin’s picture

andregriffin commented

Very good. The main reason why I wanted to adjust the tpl was due to how the search is displayed in the collapsed nav. It would be nice to keep the search at the very bottom in the collapsed nav, rather than splitting up primary and secondary links. But maybe that can be done with just some CSS.

markhalliwell’s picture

markhalliwell
Primary language English
commented
StatusFileSize
new interdiff.txt777 bytes
new bootstrap-search-block-broken-1993968-7.patch11.87 KB

Ah, good point. Well, we'd have to move it after the primary and second navs then. There's really no way to get around markup order on mobile. Added back the tpl changes, guess if anyone wants it differently they can override it.

markhalliwell’s picture

markhalliwell
Primary language English
commented

Pretty sure I just fixed #1994044-2: .element-invisible causes mobile to scroll horizontally, would you mind testing it. Thanks!

andregriffin’s picture

andregriffin commented
Status: Needs review » Fixed

http://drupalcode.org/project/bootstrap.git/commit/a83f51b

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.