Hi,

If signup.module is given a node where $form['nid']['#value'] is set but not filled, node.module throws a SQL error as the $params array isn't correctly filled. I've attached a simple patch which fixes this issue.

This is most noticeable when webform is used, as you will get the error when you submit a component to add to the form.

Thanks,
--Andrew

CommentFileSizeAuthor
node_load_fix.patch483 bytesdeviantintegral

Comments

dww’s picture

dww
we/he/they
commented
Status: Needs review » Needs work

Thanks for the report and patch. No need to keep the isset() since you're using !empty(). Otherwise, looks good.

dww’s picture

dww
we/he/they
commented
Status: Needs work » Fixed

Tested briefly. I couldn't reproduce the bug, since I didn't quite understand what you mean about webform triggering the problem. However, it seems like a safe move, and nothing appeared to break by moving from isset() to !empty(). So, I committed the modified version to HEAD, DRUPAL-5 and DRUPAL-4-7. Thanks.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.