The 2026 Drupal Business Survey is open. Your response will help shape the future of the Drupal business ecosystem.I use search_api_db to execute my searches. I had an infinite recursion in the "create_keys_query" when my search terms contained stopwords. While debugging, I noticed that "processor_stopwords" - "process" unsets the value of the stopword term in the "filters" array (in processor.inc - processFilters) but the entry in the filters array is retained (with an empty value). This causes an infinite recursion as mentioned before. I fixed this by unsetting the entry in the filters array when the value is emptied by a processor , which can be reviewed in the patch I've attached.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | 1993536-2--processors_removing_filters.patch | 3.57 KB | drunken monkey |
| search_api_stopwords_processor_infinite_recursion.patch | 877 bytes | johanpieck |
Comments
Comment #2
drunken monkeyThanks for reporting and even providing a patch! Your approach looks already very good, but it has a serious flaw: you'd also sort out all filters for 0, no matter whether the filter value was actually changed. It is also possible to filter for
NULLvalues, which your patch would forbid, too.Attached is a patch that tries its best to avoid any unwanted side effects. Filters are only excluded when the value was changed to an empty string (not 0,
NULL,FALSE, …).Thinking about it, I also realized that processors would currently also work on these non-string values and convert them to strings, thus resulting in possibly wrong queries (e.g., when
NULLis replaced by an empty string). This should be fixed by the attached patch, too.Please test whether this works for you!
Also, please always create patches relative to the module's directory, not your web root. See the handbook for details.
Comment #3
drunken monkeyComment #4
johanpieck commentedHello drunken monkey, I can confirm this patch works. Thanks!
I realized that my patch contained corrupt paths and was in the process of creating a new one, but you were faster :-).
Comment #5
drunken monkeyThanks for testing, and thanks again for your patch!
Committed.