By joachim on
Change record status: 
Published (View all published change records)
Project: 
Flag
Introduced in branch: 
7.x-3.x
Introduced in version: 
7.x-3.0-beta1
Issue links: 
https://www.drupal.org/node/1991336
Description: 

The theme() method on the $flag handler is a wrapper around theme_flag(), which allows easy creation of flag links.

It had two optional parameters which were doing double duty with a more general $variables parameter which allowed variables to be passed directly through to the template:

   * @param $after_flagging = FALSE
   *  (Optional) Set to TRUE if this flag link is being displayed as the result
   *  of a flagging action.
   * @param $errors = array()
   *  An array of error messages.

These have been removed. If they need to be set, they should be passed in the $variables array.

Before:

'newLink' => $flag->theme($flag->is_flagged($entity_id) ? 'unflag' : 'flag', $entity_id, TRUE, $errors),

After:

    'newLink' => $flag->theme($flag->is_flagged($entity_id) ? 'unflag' : 'flag', $entity_id, array(
      'after_flagging' => TRUE,
      'errors' => $errors,
    )),
Impacts: 
Module developers
Themers