og_ungroup's documentation is outdated

CommentFileSizeAuthor
#4 og-updates_og_ungroup_doc-1992430-4.patch1.04 KBwundo
#1 og-updates_og_ungroup_doc-1992430-1.patch910 byteswundo

Comments

wundo’s picture

wundo commented
Title: Update og_ungroup documentation » og_ungroup documentation is currently wrong
StatusFileSize
new og-updates_og_ungroup_doc-1992430-1.patch910 bytes

this patch fixes it ;)

wundo’s picture

wundo commented
Status: Active » Needs review
danylevskyi’s picture

danylevskyi
Location Myrhorod / Ukraine
commented
Status: Needs review » Needs work 
+++ b/og.moduleundefined
@@ -1980,9 +1980,13 @@ function og_group($group_type, $gid, $values = array(), $save_created = TRUE) {
  * @param $entity_type

Please, mention that this parameter is optional.

+++ b/og.moduleundefined
@@ -1980,9 +1980,13 @@ function og_group($group_type, $gid, $values = array(), $save_created = TRUE) {
+ * @param $etid

This parameter is also optional.

Please, use (optional) keyword. See http://drupal.org/coding-standards/docs

wundo’s picture

wundo commented
Status: Needs work » Needs review
StatusFileSize
new og-updates_og_ungroup_doc-1992430-4.patch1.04 KB

Added the optional tag to the parameter.

danylevskyi’s picture

danylevskyi
Location Myrhorod / Ukraine
commented
Status: Needs review » Reviewed & tested by the community

Thanks!

amitaibu’s picture

amitaibu
Primary language Hebrew
Location Israel
commented
Status: Reviewed & tested by the community » Fixed

Committed, thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.