Closed (won't fix)
Project:
Webform
Version:
7.x-4.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
7 May 2013 at 07:28 UTC
Updated:
17 Feb 2014 at 00:00 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
sharique commentedHere is the patch, build against 3.x branch.
Comment #2
sharique commentedI also added panel page (ctools task) for webform submissions, so you don't need pm_existing pages module any more. please review.
Comment #3
rajiv.singh commentedLooks good to me
Comment #4
quicksketchI don't regularly use Panels, so I'm not super-keen on including this in the main module.
This bit of code seems rather hackish, shouldn't there be a way to get information without using arg() here? And combining everything into
$data->{$component['form_key']}won't work because form keys are not unique, they're allowed to duplicate as long as they're on different pages or fieldsets.This kind of use of GLOBALs and variables isn't going to fly either:
Comment #5
sharique commentedI'm also newbee at panels coding, I just copied over node_view task and done changes according requirements.
Comment #6
sharique commentedHere is updated patch. I only able to use if GLOBALs, it getting nid,sid in $data hence not able to remove arg().
Comment #7
quicksketchI've been using Panels more regularly recently, but from the looks of this patch, this isn't code that I'd be comfortable maintaining within the project. I don't really understand what this code is doing (possibly due to Panels/Page Manager rather than this code itself) so I'd rather see this live as a stand-alone project for the time being. Even though I'm using Panels on almost every project these days, and I use Webform on every project, the need to combine both of them isn't a scenario I've encountered. So I hope I'm not over-extrapolating my individual experience here, but for me the maintenance cost compared to the reward aren't in balance.
I'm open to reconsideration. But this doesn't look like a good fit for the main project to me.