Convert system_test callbacks to a new style controller

attached is a first run at this patch.

I doubt this will fix the tests, but it makes the class a little cleaner. Someone that knows how drupal_register_shutdown_function works is probably going to have to dig into or give guidance on this issue.

Thanks for your work on this issue! Please see #1971384-43: [META] Convert page callbacks to controllers for an update on the routing system conversion process.

@vks7056: if you feel that patch is ready for review, please change issue status to 'Needs review'

Setting to 'needs review' for the testbot.

Needs reroll.

Trying to reroll.

Trying to fix the tests

1. +++ b/core/modules/system/tests/modules/system_test/src/Controller/SystemTestController.php
   @@ -76,17 +77,30 @@ public function drupalSetMessageTest() {
   +    if (\Drupal::lock()->acquire('system_test_lock_acquire')) {
   +      \Drupal::lock()->release('system_test_lock_acquire');
   ...
   +    if (\Drupal::lock()->acquire('system_test_lock_exit', 900)) {
   

   lock service needs injection

2. +++ b/core/modules/system/tests/modules/system_test/src/Controller/SystemTestController.php
   @@ -132,10 +146,14 @@ public static function preRenderCacheTags($elements) {
   +    $authorize_url = $GLOBALS['base_url'] . '/core/authorize.php';
   

   suppose globals access should be removed

Let's try again

I need help

+    $authorize_url = Url::fromUri('base:core/authorize.php')->toString();

is not the same as

$authorize_url = $GLOBALS['base_url'] . '/core/authorize.php';

So what should it be?

+++ b/core/modules/system/tests/modules/system_test/src/Controller/SystemTestController.php
@@ -132,10 +157,14 @@ public static function preRenderCacheTags($elements) {
   public function authorizeInit($page_title) {
-    return system_test_authorize_init_page($page_title);
+    $authorize_url = Url::fromUri('base:core/authorize.php')->toString();
+    system_authorized_init('system_test_authorize_run', drupal_get_path('module', 'system_test') . '/system_test.module', array(), $page_title);
+    return new RedirectResponse($authorize_url);
   }

RedirectRepsonse expects absolute urls.

Whoeha THNX!

Great!

This is test only code and part of the WSCCI conversions hence allowable during beta. Committed e132a97 and pushed to 8.0.x. Thanks!