Part of #1971384: [META] Convert page callbacks to controllers

For instructions on how to convert a page callback into a controller, see the WSCCI Conversion Guide.

Files: 
CommentFileSizeAuthor
#8 date-1987822-8.patch726 bytestim.plunkett
PASSED: [[SimpleTest]]: [MySQL] 58,114 pass(es).
[ View ]
#4 1987822-route-date-time-4.patch1.37 KBjrglasgow
FAILED: [[SimpleTest]]: [MySQL] 55,747 pass(es), 1 fail(s), and 0 exception(s).
[ View ]
#1 1987822-route-date-time-1.patch2.3 KBvijaycs85
PASSED: [[SimpleTest]]: [MySQL] 55,920 pass(es).
[ View ]

Comments

vijaycs85’s picture

Status:Active» Needs review
StatusFileSize
new2.3 KB
PASSED: [[SimpleTest]]: [MySQL] 55,920 pass(es).
[ View ]

Initial patch...

cosmicdreams’s picture

patch doesn't apply.

dawehner’s picture

Status:Needs review» Needs work

This should also remove the existing code.

jrglasgow’s picture

Status:Needs work» Needs review
StatusFileSize
new1.37 KB
FAILED: [[SimpleTest]]: [MySQL] 55,747 pass(es), 1 fail(s), and 0 exception(s).
[ View ]

rerolled the patch

dawehner’s picture

Status:Needs review» Needs work

You missed the controller.

InternetDevels’s picture

Assigned:Unassigned» InternetDevels

We are working today with this issue during Code Sprint UA.

InternetDevels’s picture

Assigned:InternetDevels» Unassigned

.

tim.plunkett’s picture

Status:Needs work» Needs review
StatusFileSize
new726 bytes
PASSED: [[SimpleTest]]: [MySQL] 58,114 pass(es).
[ View ]
dawehner’s picture

Status:Needs review» Reviewed & tested by the community

Yeah just #ajax is used here.

Crell’s picture

I find no errors in the code in the patch. :-)

Dries’s picture

Status:Reviewed & tested by the community» Fixed

Committed to 8.x. Thanks.

jcisio’s picture

Status:Fixed» Active

The change in yml file was not committed.

jcisio’s picture

Status:Active» Fixed

Sorry, wrong patch.

Automatically closed -- issue fixed for 2 weeks with no activity.