Deleting recurring entities always reports an error despite operation success

Yeah, this one was already there ;)
#1974664: Review the delete recurring entity process

This is slightly different issue, the message for unsuccessful deletion appears because entity->delete() function will not return anything on success, just empty result!
See: http://drupalcontrib.org/api/drupal/contributions%21entity%21includes%21...
That’s why to avoid that error message the code needs to be reshuffled. A patch is attached

Bumped into the same issue, this patch fixes it.

Cool, thanks. We need a test and we're good to go.

I created a new commerce_recurring_ui.test file but wanted to use some of the helper functions in commerce_recurring.test so I moved those to a new file commerce_recurring_base.test.

Lot's of moving around for such a small test, I hope this is not out of scope for this.

edit: forgot to add a new line to the commerce_recurring_ui.info file, I guess this can be fixed on commit if this is green.

Patch in #2 fixed it for me.

Instead of calling $entity->delete and checking status, we need to check if the entity still exists. Calling entity_delete or $entity->delete() will always return nothing of value.

Never mind, unrelated issue.

Per @heddn's feedback, here is an updated patch that checks for the existence of the recurring entity after it has been deleted.

Please review, thanks.

This looks good to me. Thanks ron_s, this looks like the best solution.