menu_node_submit() calls entity_create() when $form_state['values']['menu'] is empty which results in the following message appearing:

Warning: Invalid argument supplied for foreach() in Drupal\Core\Entity\Entity->__construct() (line 72 of core/lib/Drupal/Core/Entity/Entity.php).

CommentFileSizeAuthor
#16 node-dependency-1986000-16.patch563 bytesberdir
#10 missing-menu-fatal-error-1986000-10-test-only.patch2.12 KBberdir
#10 missing-menu-fatal-error-1986000-10.patch3.31 KBberdir
#3 1986000-3.patch1.19 KBalphawebgroup

Comments

benjy’s picture

benjy commented

Can you provide the steps to reproduce against the latest head. I'm unable to replicate by adding menu links, or content with menu entries.

idflood’s picture

idflood commented

I've found the same issue. Here are the steps to reproduce:

  1. Create a new content type (or edit an existing one).
  2. In the "Menu settings" tab uncheck all "Available menus".
  3. Create a new content.

edit: here is some relevant lines of the backtrace

Drupal\Core\Entity\Entity->__construct(NULL, 'menu_link')
Drupal\Core\Entity\DatabaseStorageController->create(NULL)
Drupal\menu_link\MenuLinkStorageController->create(NULL)
entity_create('menu_link', NULL)
menu_node_submit(Object, Array, Array)
Drupal\node\NodeFormController->submit(Array, Array)
call_user_func_array(Array, Array)
form_execute_handlers('submit', Array, Array)
drupal_process_form('note_node_form', Array, Array)
drupal_build_form('note_node_form', Array)
Drupal\Core\Entity\EntityManager->getForm(Object)
node_add(Object)
call_user_func_array('node_add', Array)
...
idflood’s picture

idflood commented
Issue summary: View changes

Added code tags

alphawebgroup’s picture

alphawebgroup
he/him
Primary language English
Location Kyiv / Toronto
commented
Assigned: Unassigned » alphawebgroup
Issue summary: View changes
StatusFileSize
new 1986000-3.patch1.19 KB
alphawebgroup’s picture

alphawebgroup
he/him
Primary language English
Location Kyiv / Toronto
commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 3: 1986000-3.patch, failed testing.

alphawebgroup’s picture

alphawebgroup
he/him
Primary language English
Location Kyiv / Toronto
commented
Status: Needs work » Needs review

3: 1986000-3.patch queued for re-testing.

Blooniverse’s picture

Blooniverse commented
Status: Needs review » Reviewed & tested by the community

#3: 1986000-3.patch works, for me. Thanks for the work!
Changing status to RTBC.

xjm’s picture

xjm
she/her
Primary language English
commented

3: 1986000-3.patch queued for re-testing.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs tests

Nice catch! Let's get an automated test added for this.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Assigned: alphawebgroup » Unassigned
Priority: Normal » Minor
Status: Needs work » Needs review
Issue tags: -Needs tests
StatusFileSize
new missing-menu-fatal-error-1986000-10.patch3.31 KB
new missing-menu-fatal-error-1986000-10-test-only.patch2.12 KB

This is now a recoverable fatal error that prevents creating nodes with that configuration, so raising to major.

Attached patch adds tests and as a bonus, converts MenuNodeTest to not use the standard profile which means that the test is now ~3 times faster :)

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Priority: Minor » Major

Uhm. The other major ;)

draganeror’s picture

draganeror
Primary language Serbian
Location Novi Sad
commented
Status: Needs review » Reviewed & tested by the community

Tested patch from #10, works nice.

  1. Created content of content type Article, saved, edited, saved.
  2. Changed content type Article settings, removed all available menus.
  3. Edited same Article content again, saved. It works! :)

Thanks Berdir

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 10: missing-menu-fatal-error-1986000-10-test-only.patch, failed testing.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs work » Reviewed & tested by the community

Had the test only patch in the wrong order, this passed/failed as expected.

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.x, thanks!

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Title: Warning when adding content with an empty menu path » HEAD BROKEN: Warning when adding content with an empty menu path
Priority: Major » Critical
Status: Fixed » Needs review
StatusFileSize
new node-dependency-1986000-16.patch563 bytes

Ok, bad timing, this conflicted with https://drupal.org/node/1541298 and needs an exlicit dependency on node now.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Title: HEAD BROKEN: Warning when adding content with an empty menu path » Warning when adding content with an empty menu path
Priority: Critical » Major
Status: Needs review » Fixed

Committed 21fca46 and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.