Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
This is a great module, but it sort of worries me that there are no tests written for it.
Comment | File | Size | Author |
---|---|---|---|
#9 | subscriptions-initial_test_cases_added-1984584-9.patch | 17.31 KB | bulat |
#7 | subscriptions-initial_test_cases_added-1984584-7.patch | 8.42 KB | bulat |
#5 | subscriptions-initial_test_cases_added-1984584-5.patch | 7.57 KB | bulat |
Comments
Comment #1
salvisFeel free to start writing tests or to hire someone to do it.
Comment #2
bulat CreditAttribution: bulat commentedI guess that should be done while functionality is added or bugs are fixed as well. We will write test for subscriptions reference module that we are developing. I will post our integration tests once they are ready.
Comment #3
bulat CreditAttribution: bulat commentedHere is what we came up with so far:
http://drupalcode.org/sandbox/bulat/1990654.git/blob/HEAD:/subscriptions...
Following class can be used as a base for test cases for Subscriptions:
Comment #4
salvisThis looks very interesting, but please post a patch. Reviewing code that is not in patch format is difficult and error-prone.
Comment #5
bulat CreditAttribution: bulat commentedPlease see the patch with the base class
SubscriptionsTestCase
that extendsDrupalWebTestCase
and sample test forsubscriptions_content
.Comment #7
bulat CreditAttribution: bulat commentedAdded include to fix the test case.
Comment #8
salvisWow, this is great — thank you very much!
Unfortunately, you have quite a few violations of the http://drupal.org/coding-standards
Needs trailing newline.
Comments must end with a period.
The first of many trailing spaces.
Use Dreditor to look at your patch, or set your editor to remove those trailing spaces.
This must be formatted as (see http://drupal.org/node/1354):
Always indent 2 positions per level.
All comments must start in upper case and end with a period.
Typo.
Period at the end of the first line, then an empty line; no trailing empty line.
These are all minor issues, but the sooner you learn to follow the Drupal guidelines the better you'll fit into the Drupal community.
Requiring third-party libraries (pecl, apd, runkit) is not supported by the testbot AFAIK, which would defeat the automated testing, unfortunately.
Comment #9
bulat CreditAttribution: bulat commentedThank you for the review. Here is the new patch.
Comment #10
vuilThe patch #9 needs to be re-rolled.