The 2026 Drupal Business Survey is open. Your response will help shape the future of the Drupal business ecosystem.Some of the patches we submitted that made it into D6 did not make it into D7.
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | interdiff.txt | 426 bytes | joelpittet |
| #6 | d7_patches-1984210-6.patch | 5.66 KB | joelpittet |
| #5 | d7_patches-1984210-5.patch | 5.66 KB | joelpittet |
| #1 | olark-suppress_roles-1984210-1.patch | 5.31 KB | jsagotsky |
Comments
Comment #1
jsagotsky commentedI had to bake a few patches together to get them to apply cleanly. They serve a similar purpose so I don't feel too dirty about that.
http://drupal.org/node/1418930 - hook suppress. Lets you block olark from showing up in popup windows and overlays.
http://drupal.org/node/1858372 - roles restriction. Okay, there is a d7 version of this, but I couldn't get it to apply cleanly with the other ones so it's baked in.
attached js - (The dev who set up this one never submitted it. For shame!) Uses render arrays #attached property to add the javascript to a page instead of blindly doing drupal_add_js. The advantage is that if the footer doesn't print, the js won't attach in places we don't want it.
Comment #2
jsagotsky commentedSee also http://drupal.org/node/1785322#comment-7364524 for the js function check patch.
Comment #3
joelpittetThe coding standards on this patch need some love.
2 Space indents instead of tabs, wrap at 80 chars, and that one return comment is overkill. There may be more as it's cleaned up.
Comment #4
joelpittetThere is some good stuff in this patch. May want to merge with the very similar code provided here #1858372: Forward Port Drupal 6 version to surpress olark for particular roles
Comment #5
joelpittetOk most of this has been committed already about the roles. Here is just the nice #attached stuff left.
Comment #6
joelpittetTypo in last patch.
Comment #7
joelpittetThat does the trick, committed thanks @jsagotsky for helping.