Follow up for #1953404: Add config schema to field and instance config entities
Problem/motivation
#1866610: Introduce Kwalify-inspired schema format for configuration introduced the idea of config schema. The changelog leads to (hopefully extensive) documentation on the format at http://drupal.org/node/1905070. As a part of schema addition to field module(#1953404: Add config schema to field and instance config entities), found that we have to provide schema for field types, field widgets and field storage.
Proposed solution
Create a configuration schema for field types, field widget and field storage (if applicable) defined in telephone module.
Schema in place
Schema not in place
field.telephone.settings
field.telephone.instance_settings
field.telephone.value
field_widget.telephone_default.settings
Comment | File | Size | Author |
---|---|---|---|
#10 | interdiff.txt | 637 bytes | swentel |
#10 | 1983912-field-config-schema-telephone-10.patch | 661 bytes | swentel |
#8 | 1983912-field-config-schema-telephone-8.patch | 863 bytes | vijaycs85 |
#8 | 1983912-diff-2-8.txt | 580 bytes | vijaycs85 |
#4 | field.field_.telephone.png | 35.54 KB | vijaycs85 |
Comments
Comment #1
vijaycs85Comment #2
vijaycs85Initial patch...
Comment #4
vijaycs85Adding config_inspector screenshots.
Comment #5
swentel CreditAttribution: swentel commentedWidget needs to go out after #1875992: Add EntityFormDisplay objects for entity forms got in.
Comment #6
Dave ReidWell #1875992: Add EntityFormDisplay objects for entity forms is in now, so we should continue with this. I haven't worked with the config schema before and am not sure what is right and what is wrong. Anyone want to continue this patch?
Comment #7
vijaycs85Comment #8
vijaycs85Removing widget.
Comment #9
aspilicious CreditAttribution: aspilicious commenteduser_register_form stuff doesn't exist anymore
Comment #10
swentel CreditAttribution: swentel commentedComment #11
aspilicious CreditAttribution: aspilicious commentedI don't think you can leave the instance settings schema empty. Can you provide a screenshot of the config inspector. I suspect default value being something incorrect. (wild guess based on other patches)
Comment #12
vijaycs85The patch on this issue has been updated as part of #2167623: Add test for all default configuration to ensure schema exists and is correct. As this issue doesn't have any test to confirm/validate the schema, making this change and closing this issue as duplicate of #2167623: Add test for all default configuration to ensure schema exists and is correct. The contributors of this issue (in commit message) is copied to #2167623: Add test for all default configuration to ensure schema exists and is correct.