Follow up for #1953404: Add config schema to field and instance config entities

Problem/motivation

#1866610: Introduce Kwalify-inspired schema format for configuration introduced the idea of config schema. The changelog leads to (hopefully extensive) documentation on the format at http://drupal.org/node/1905070. As a part of schema addition to field module(#1953404: Add config schema to field and instance config entities), found that we have to provide schema for field types, field widgets and field storage.

Proposed solution

Create a configuration schema for field types, field widget and field storage (if applicable) defined in telephone module.
Schema in place

Schema not in place
field.telephone.settings
field.telephone.instance_settings
field.telephone.value

field_widget.telephone_default.settings

Files: 
CommentFileSizeAuthor
#10 interdiff.txt637 bytesswentel
#10 1983912-field-config-schema-telephone-10.patch661 bytesswentel
PASSED: [[SimpleTest]]: [MySQL] 59,351 pass(es).
[ View ]
#8 1983912-field-config-schema-telephone-8.patch863 bytesvijaycs85
PASSED: [[SimpleTest]]: [MySQL] 57,514 pass(es).
[ View ]
#8 1983912-diff-2-8.txt580 bytesvijaycs85
#4 field.field_.telephone.png35.54 KBvijaycs85
#4 field.instance.telephone.png44.37 KBvijaycs85
#2 1983912-field-config-schema-telephone-2.patch1.02 KBvijaycs85
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git].
[ View ]

Comments

vijaycs85’s picture

Title:Copy of Copy of Provide config schema to field types, widgets and storage in telephone module» Provide config schema to field types, widgets and storage in telephone module
vijaycs85’s picture

Status:Active» Needs review
StatusFileSize
new1.02 KB
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git].
[ View ]

Initial patch...

Status:Needs review» Needs work

The last submitted patch, 1983912-field-config-schema-telephone-2.patch, failed testing.

vijaycs85’s picture

Status:Needs work» Needs review
StatusFileSize
new44.37 KB
new35.54 KB

Adding config_inspector screenshots.

swentel’s picture

Title:Provide config schema to field types, widgets and storage in telephone module» Provide config schema to field types and storage in telephone module
Status:Needs review» Needs work

Widget needs to go out after #1875992: Add EntityFormDisplay objects for entity forms got in.

Dave Reid’s picture

Well #1875992: Add EntityFormDisplay objects for entity forms is in now, so we should continue with this. I haven't worked with the config schema before and am not sure what is right and what is wrong. Anyone want to continue this patch?

vijaycs85’s picture

Issue tags:+LONDON_2013_JULY
vijaycs85’s picture

Status:Needs work» Needs review
StatusFileSize
new580 bytes
new863 bytes
PASSED: [[SimpleTest]]: [MySQL] 57,514 pass(es).
[ View ]

Removing widget.

aspilicious’s picture

Issue summary:View changes
Status:Needs review» Needs work

user_register_form stuff doesn't exist anymore

swentel’s picture

Status:Needs work» Needs review
StatusFileSize
new661 bytes
PASSED: [[SimpleTest]]: [MySQL] 59,351 pass(es).
[ View ]
new637 bytes
aspilicious’s picture

I don't think you can leave the instance settings schema empty. Can you provide a screenshot of the config inspector. I suspect default value being something incorrect. (wild guess based on other patches)

vijaycs85’s picture

Status:Needs review» Closed (duplicate)
Related issues:+#2167623: Add test for all default configuration to ensure schema exists and is correct

The patch on this issue has been updated as part of #2167623: Add test for all default configuration to ensure schema exists and is correct. As this issue doesn't have any test to confirm/validate the schema, making this change and closing this issue as duplicate of #2167623: Add test for all default configuration to ensure schema exists and is correct. The contributors of this issue (in commit message) is copied to #2167623: Add test for all default configuration to ensure schema exists and is correct.