Use API provided by ga_push

I am taking a deeper look into this now. If everything goes well I will release a second dev branch with the implementation soon.

As the issue #1984858 says: http://drupal.org/node/1984858 the next ga_push parameters have been changed to an associative array, currently on dev branch. This will be on the stable branch next week.

<?php
/**
 * API for other modules to call in order to add events to the queue.
 *
 * @param push (Array)
 * push parameters.
 * Structure:
 *
 * EVENT:
 *  array(
 *    'category'        => 'Videos',              // (required) The name you supply for the group of objects you want to track.
 *    'action'          => 'Play',                // (required) A string that is uniquely paired with each category, and commonly used to define the type of user interaction for the web object.
 *    'label'           => 'Gone With the Wind',  // (optional) An optional string to provide additional dimensions to the event data.
 *    'value'           => 1,                     // (optional) An integer that you can use to provide numerical data about the user event.
 *    'non-interaction' => false,                 // (optional) A boolean that when set to true, indicates that the event hit will not be used in bounce-rate calculation.
 *  );
 *
 * ECOMMERCE:
 *  array(
 *    'trans' => array(
 *      'order_id' => '1234',           // order ID - required
 *      'affiliation' => 'Acme Clothing',  // affiliation or store name
 *      'total' => '11.99',          // total - required
 *      'total_tax' => '1.29',           // tax
 *      'total_shipping' => '5',              // shipping
 *      'city' => 'San Jose',       // city
 *      'region' => 'California',     // state or province
 *      'country' => 'USA'             // country
 *    ),
 *    'items' => array(
 *      array(
 *        'order_id' => '1234',         // order ID - required
 *        'sku' => 'DD44',         // SKU/code - required
 *        'name' => 'T-Shirt',      // product name
 *        'category' => 'Green Medium', // category
 *        'price' => '11.99',        // unit price - required
 *        'quantity' => '1'             // quantity - required
 *      ),
 *    ),
 *  )
 *
 *
 * @param type String
 * The GA PUsh type: Event, Ecommerce... Use the defined constants
 * @param method_key String
 * The method identificator
 */
function ga_push_add($push, $type = GA_PUSH_TYPE_EVENT, $method_key = NULL)
?>

I just created a new dev Release which uses the ga_push module as new api for sending the transactions. When available to download, please test this version and make new issues for each error with the new version as tag.

I would suggest to mark this as fixed when we release Version 2.0

Hi Cyberschorsch!
In the current 7.x-2.x branch the commerce_google_analytics_build_push_array() there are missing the items (line_items) params, only the transaction is being returned and some keys are not named properly.

Attaching a patch that includes it.

Thanks stevepurkiss! Attaching a new patch with "quantity" key.

Thank you both for working on this.

The patch needs a little bit of work. Please check if it applys to the coding standards (see whitespaces).

Checked the *.module file with: https://drupal.org/project/coder : Drupal CodeSniffer, Drupal Coding Standards, Drupal Commenting Standards, Drupal SQL Standards, Drupal Security Checks.

No errors found, if you find one just tell me to generate a new patch. There some coding standard issues on the other files but I think this should be on a different issue or patch.

Needs review

Thank you guys for fixing this. I will close this ticket. For new issues, please open a new ticket in the issue queue.