Drop procedural usage of fields in [t*] modules

Part of #1953410: [Meta] Remove field_create_*(), field_update_*() and field_delete_*() in favor of just using the ConfigEntity API

Comment	File	Size	Author
#27	1981336-26.patch	28.62 KB	amateescu
#21	1981336-21.patch	28.56 KB	aspilicious
#19	1981336-19.patch	28.56 KB	aspilicious
#17	1981336-17.patch	26.42 KB	aspilicious
#15	1981336-15.patch	26.43 KB	aspilicious
#13	1981336-13.patch	26.43 KB	aspilicious
#13	1981336-13-interdiff.txt	21.54 KB	aspilicious
#11	1981316-13.patch	28.14 KB	aspilicious
#11	1981316-13-interdiff.txt	21.72 KB	aspilicious
#7	1981336-6.patch	20.38 KB	swentel
#1	1953410-cud-1981336-1.patch	21.37 KB	andypost

Comments

Comment #1

he/him

Russian

commented 27 April 2013 at 18:31

Status:

Active

» Needs review

Status	File	Size
new	1953410-cud-1981336-1.patch	21.37 KB

Log in or register to post comments

Comment #2

he/him

Russian

commented 27 April 2013 at 22:19

Issue tags:

tagged to office hours

Log in or register to post comments

swentel’s picture

Comment #3

swentel commented 28 April 2013 at 13:03

Status:

Needs review

» Closed (won't fix)

We're going todo this in one patch.

Log in or register to post comments

swentel’s picture

Comment #4

swentel commented 6 June 2013 at 11:13

Status:

Closed (won't fix)

» Needs review

So we agreed to this in chunks anyway.

Log in or register to post comments

swentel’s picture

Comment #5

swentel commented 6 June 2013 at 11:13

Issue tags:

-Novice, -Field API

#1: 1953410-cud-1981336-1.patch queued for re-testing.

Log in or register to post comments

Comment #6

6 June 2013 at 11:27

Status:	Needs review	» Needs work
Issue tags:		+Novice, +Field API

The last submitted patch, 1953410-cud-1981336-1.patch, failed testing.

Log in or register to post comments

swentel’s picture

Comment #7

swentel commented 6 June 2013 at 11:58

Status:

Needs work

» Needs review

Status	File	Size
new	1981336-6.patch	20.38 KB

rerolled

Log in or register to post comments

aspilicious’s picture

Comment #8

aspilicious commented 8 June 2013 at 13:46

Status:

Needs review

» Reviewed & tested by the community

Log in or register to post comments

aspilicious’s picture

Comment #9

aspilicious commented 8 June 2013 at 13:47

Log in or register to post comments

aspilicious’s picture

Comment #10

aspilicious commented 8 June 2013 at 13:54

Status:

Reviewed & tested by the community

» Needs review

back to nr for now, other issue has some interesting comments

Log in or register to post comments

aspilicious’s picture

Comment #11

aspilicious commented 8 June 2013 at 17:45

Status	File	Size
new	1981316-13-interdiff.txt	21.72 KB
new	1981316-13.patch	28.14 KB

Changes in line with the other issues

Log in or register to post comments

Comment #12

8 June 2013 at 18:07

Status:

Needs review

» Needs work

The last submitted patch, 1981316-13.patch, failed testing.

Log in or register to post comments

aspilicious’s picture

Comment #13

aspilicious commented 8 June 2013 at 18:12

Status:

Needs work

» Needs review

Status	File	Size
new	1981336-13-interdiff.txt	21.54 KB
new	1981336-13.patch	26.43 KB

wrong patch and interdiff

Log in or register to post comments

Comment #14

8 June 2013 at 18:46

Status:

Needs review

» Needs work

The last submitted patch, 1981336-13.patch, failed testing.

Log in or register to post comments

aspilicious’s picture

Comment #15

aspilicious commented 8 June 2013 at 19:07

Status:

Needs work

» Needs review

Status	File	Size
new	1981336-15.patch	26.43 KB

Argh!

Log in or register to post comments

Comment #16

8 June 2013 at 19:39

Status:

Needs review

» Needs work

The last submitted patch, 1981336-15.patch, failed testing.

Log in or register to post comments

aspilicious’s picture

Comment #17

aspilicious commented 9 June 2013 at 14:39

Status:

Needs work

» Needs review

Status	File	Size
new	1981336-17.patch	26.42 KB

!é"*ù%£%!!!

Log in or register to post comments

Comment #18

9 June 2013 at 17:28

Status:

Needs review

» Needs work

The last submitted patch, 1981336-17.patch, failed testing.

Log in or register to post comments

aspilicious’s picture

Comment #19

aspilicious commented 10 June 2013 at 19:17

Status:

Needs work

» Needs review

Status	File	Size
new	1981336-19.patch	28.56 KB

Needed a reroll and fixed the tests... I hope...

Log in or register to post comments

Comment #20

11 June 2013 at 00:15

Status:

Needs review

» Needs work

The last submitted patch, 1981336-19.patch, failed testing.

Log in or register to post comments

aspilicious’s picture

Comment #21

aspilicious commented 11 June 2013 at 09:01

Status:

Needs work

» Needs review

Status	File	Size
new	1981336-21.patch	28.56 KB

Log in or register to post comments

Comment #22

11 June 2013 at 13:35

Status:	Needs review	» Needs work
Issue tags:	-Novice, -Field API

The last submitted patch, 1981336-21.patch, failed testing.

Log in or register to post comments

aspilicious’s picture

Comment #23

aspilicious commented 11 June 2013 at 13:45

Status:	Needs work	» Needs review
Issue tags:		+Novice, +Field API

#21: 1981336-21.patch queued for re-testing.

Log in or register to post comments

swentel’s picture

Comment #24

swentel commented 12 June 2013 at 07:00

Status:

Needs review

» Reviewed & tested by the community

Alright, first one good to go!

Log in or register to post comments

Comment #25

he/they

English

🇪🇺🌍

commented 17 June 2013 at 20:03

Issue tags:

-Novice, -Field API

#21: 1981336-21.patch queued for re-testing.

Log in or register to post comments

Comment #26

17 June 2013 at 20:06

Status:	Reviewed & tested by the community	» Needs work
Issue tags:		+Novice, +Field API

The last submitted patch, 1981336-21.patch, failed testing.

Log in or register to post comments

Comment #27

amateescu commented 17 June 2013 at 20:07

Status:

Needs work

» Reviewed & tested by the community

Status	File	Size
new	1981336-26.patch	28.62 KB

Rerolled after #1950632: Create a FieldDefinitionInterface and use it for formatters and widgets

Log in or register to post comments

Comment #28

he/they

English

🇪🇺🌍

commented 18 June 2013 at 10:48

Status:

Reviewed & tested by the community

» Fixed

Committed 5eff1db and pushed to 8.x. Thanks!

Log in or register to post comments

Comment #29

2 July 2013 at 10:51

Automatically closed -- issue fixed for 2 weeks with no activity.

Log in or register to post comments