Drop procedural usage of fields in field_sql_storage & field_ui tests

We're going todo this in one patch.

So we agreed to this in chunks anyway.

#1: 1981292-1.patch queued for re-testing.

Re-rolled - it's a bit smaller now that entityformdisplay is in.

Lets see how hard this fails (or not)

Not everything seems related, lets retest

#9: 1981292-9.patch queued for re-testing.

Should be better

Hmm

Patch had a couple of syntax errors on FieldSqlStorageTest so I fixed those and removed a non-desired Views dependency changing a method.
Also improved the documentation and fixed some schema getting.

The patch won't pass yet, though. I think we've found an inconsistency here on the foreign key naming/expected naming, on testFieldSqlStorageForeignKeys test method, at the bottom, we have the following:

    $this->assertEqual(count($schema['foreign keys']), 1, 'There is 1 foreign key in the schema');
    $foreign_key = reset($schema['foreign keys']);
    $foreign_key_column = _field_sql_storage_columnname($field['field_name'], $foreign_key_name);
    $this->assertEqual($foreign_key['table'], $foreign_key_name, 'Foreign key table name preserved in the schema');
    $this->assertEqual($foreign_key['columns'][$foreign_key_column], 'id', 'Foreign key column name preserved in the schema');

So, $foreign_key['columns'][$foreign_key_column] is expecting "id" whereas the field storage column name is generating a very different column name (testfield_color):

function _field_sql_storage_columnname($name, $column) {
  return in_array($column, Field::getReservedColumns()) ? $column : $name . '_' . $column;
}

Shall I replace

$this->assertEqual($foreign_key['columns'][$foreign_key_column], 'id', 'Foreign key column name preserved in the schema');

By

$this->assertEqual($foreign_key['columns'][$foreign_key_column], 'testfield_color', 'Foreign key column name preserved in the schema');

?

The test failing is actually a sql schema test, using _field_sql_storage_schema should fix it.

Shouldn't we use $field->getSchema() (or something like that). I saw that function in the field object.

Committed 0eeda29 and pushed to 8.x. Thanks!