Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Comment | File | Size | Author |
---|---|---|---|
#21 | interdiff.txt | 1.01 KB | pcambra |
#21 | 1981292-21.patch | 17.27 KB | pcambra |
#19 | 1981292-19.patch | 17.42 KB | pcambra |
#17 | 1981292-16.patch | 17.5 KB | aspilicious |
#15 | 1981292-14.patch | 16.42 KB | aspilicious |
Comments
Comment #1
andypostPatch a bit lighter after #1946404: Convert forms in field_ui.admin.inc to the new form interface
Comment #2
andyposttagged to office hours
Comment #3
swentel CreditAttribution: swentel commentedWe're going todo this in one patch.
Comment #4
swentel CreditAttribution: swentel commentedSo we agreed to this in chunks anyway.
Comment #5
swentel CreditAttribution: swentel commented#1: 1981292-1.patch queued for re-testing.
Comment #7
swentel CreditAttribution: swentel commentedRe-rolled - it's a bit smaller now that entityformdisplay is in.
Comment #9
aspilicious CreditAttribution: aspilicious commentedLets see how hard this fails (or not)
Comment #11
aspilicious CreditAttribution: aspilicious commentedNot everything seems related, lets retest
Comment #12
aspilicious CreditAttribution: aspilicious commented#9: 1981292-9.patch queued for re-testing.
Comment #14
aspilicious CreditAttribution: aspilicious commentedShould be better
Comment #15
aspilicious CreditAttribution: aspilicious commentedComment #17
aspilicious CreditAttribution: aspilicious commentedHmm
Comment #18
andypostbundle)
Comment #19
pcambraPatch had a couple of syntax errors on FieldSqlStorageTest so I fixed those and removed a non-desired Views dependency changing a method.
Also improved the documentation and fixed some schema getting.
The patch won't pass yet, though. I think we've found an inconsistency here on the foreign key naming/expected naming, on testFieldSqlStorageForeignKeys test method, at the bottom, we have the following:
So, $foreign_key['columns'][$foreign_key_column] is expecting "id" whereas the field storage column name is generating a very different column name (testfield_color):
Shall I replace
$this->assertEqual($foreign_key['columns'][$foreign_key_column], 'id', 'Foreign key column name preserved in the schema');
By
$this->assertEqual($foreign_key['columns'][$foreign_key_column], 'testfield_color', 'Foreign key column name preserved in the schema');
?
Comment #21
pcambraThe test failing is actually a sql schema test, using _field_sql_storage_schema should fix it.
Comment #22
aspilicious CreditAttribution: aspilicious commentedShouldn't we use $field->getSchema() (or something like that). I saw that function in the field object.
Comment #23
andypostThis functions is not deprecated so ok
Comment #24
alexpottCommitted 0eeda29 and pushed to 8.x. Thanks!