We'll have to slightly modify the plugin translation system.

CommentFileSizeAuthor
#3 scald-1979024-ckeditor-plugin-translatable-3.patch3.64 KBjcisio
#1 scald_ckeditor_translation-1979024-1.patch3.4 KBti2m

Comments

ti2m’s picture

ti2m commented
Status: Active » Needs review
StatusFileSize
new scald_ckeditor_translation-1979024-1.patch3.4 KB

Hi, I'm not sure how Drupal.t could play together with CKEditor or how would you plan on doing this? As we needed german translation I adjusted dnd.js and added a german language file for now.

jcisio’s picture

jcisio commented
Status: Needs review » Active

It is hard with CKEditor native plugin, I tried and failed at #1966798: Replace usage of ckeditor_path('url') with drupal_add_js. I think we'll simply use Drupal.t because this plugin is BTW not portable outside of Drupal. We can't go back to the old school way with dozens of language files.

jcisio’s picture

jcisio commented
Status: Active » Needs review
StatusFileSize
new scald-1979024-ckeditor-plugin-translatable-3.patch3.64 KB

Like this, for example?

jcisio’s picture

jcisio commented
Status: Needs review » Fixed

Nice, it passed. Committed and pushed 6f23c8e.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.