Part of #1971384: [META] Convert page callbacks to controllers

For instructions on how to convert a page callback into a controller, see the WSCCI Conversion Guide.

Files: 
CommentFileSizeAuthor
#13 1978972-13-shortcut-controller_conversion.patch10.13 KBpfrenssen
FAILED: [[SimpleTest]]: [MySQL] 57,458 pass(es), 0 fail(s), and 4 exception(s).
[ View ]
#13 interdiff.txt588 bytespfrenssen
#8 1978972-8-shortcut-controller_conversion.patch9.7 KBpfrenssen
FAILED: [[SimpleTest]]: [MySQL] Drupal installation failed.
[ View ]
#8 interdiff.txt4.98 KBpfrenssen
#5 1978972-shortcut_link_edit-5.patch7.17 KBAjitS
PASSED: [[SimpleTest]]: [MySQL] 56,498 pass(es).
[ View ]
#3 shortcut_link_edit_1978972.patch7.27 KBdutchyoda
PASSED: [[SimpleTest]]: [MySQL] 58,144 pass(es).
[ View ]

Comments

xtfer’s picture

Assigned:Unassigned» xtfer
dutchyoda’s picture

Assigned:xtfer» dutchyoda
dutchyoda’s picture

Status:Active» Needs review
StatusFileSize
new7.27 KB
PASSED: [[SimpleTest]]: [MySQL] 58,144 pass(es).
[ View ]

I created a seperate Elements file, so it can be used in both link add and link edit.
Furthermore I made the changes to make everything work by controller.

h3rj4n’s picture

Status:Needs review» Needs work
+++ b/core/modules/shortcut/lib/Drupal/shortcut/Access/LinkEditAccessCheck.php
@@ -0,0 +1,38 @@
+}

There should be an enter at the end (multiple).

+++ b/core/modules/shortcut/lib/Drupal/shortcut/Form/Elements.php
@@ -0,0 +1,69 @@
+  /**
+   * Constructs a BookManager object.

Should be {@inheritdoc} right?

AjitS’s picture

Status:Needs work» Needs review
StatusFileSize
new7.17 KB
PASSED: [[SimpleTest]]: [MySQL] 56,498 pass(es).
[ View ]

Made changes according to #4.

AjitS’s picture

Just re-rolled the previous patch with the changes suggested. However, I see that the menu style for admin/config/user-interface/shortcut/link still needs to be changed to new routing system.
Should the status be changed to "needs work"? Or will that part be taken care of in some other issue?

h3rj4n’s picture

Status:Needs review» Needs work

No, that should be fixed in this issue. This definitely needs work! ;)

As long as the routing.yml and the hook_menu aren't changed, none of the code of the patch is tested. So that needs to be in this patch.

pfrenssen’s picture

StatusFileSize
new4.98 KB
new9.7 KB
FAILED: [[SimpleTest]]: [MySQL] Drupal installation failed.
[ View ]

I updated routing.yml and hook_menu(). The access check was identical to the one used for shortcut_link_delete, so rolled them into one.

pfrenssen’s picture

Status:Needs work» Needs review

Status:Needs review» Needs work
Issue tags:-FormInterface

The last submitted patch, 1978972-8-shortcut-controller_conversion.patch, failed testing.

pfrenssen’s picture

Status:Needs work» Needs review

Status:Needs review» Needs work
Issue tags:+FormInterface

The last submitted patch, 1978972-8-shortcut-controller_conversion.patch, failed testing.

pfrenssen’s picture

Status:Needs work» Needs review
StatusFileSize
new588 bytes
new10.13 KB
FAILED: [[SimpleTest]]: [MySQL] 57,458 pass(es), 0 fail(s), and 4 exception(s).
[ View ]

Status:Needs review» Needs work

The last submitted patch, 1978972-13-shortcut-controller_conversion.patch, failed testing.

tim.plunkett’s picture

Assigned:dutchyoda» Unassigned
Status:Needs work» Closed (duplicate)

This needs to add/change the same code as #1978966: Convert shortcut_link_add and shortcut_link_edit to a Controller, merging them.