Clean up Administrative name and description [#1977998]

Comment	File	Size	Author
#13	1977998-13.patch	2.53 KB	areke
#12	cleanupadmin.png	12.26 KB	royal121
#12	cleanupadmintitle-1977998-12.patch	2.52 KB	royal121
#4	admin.title_.cleanup.patch	2.08 KB	Bojhan
#4	admin-title-description-no-view.png	155.48 KB	Bojhan
#3	description.position.title_.patch	2.08 KB	Bojhan
#3	view-name-description-admin.png	76.91 KB	Bojhan
	administrative.title_.description.tags_.patch	1.74 KB	Bojhan
	view-name-administrative.png	91.22 KB	Bojhan
	before-view-name-human-readable.png	132.44 KB	Bojhan

Comment #1

Bojhan commented 28 April 2013 at 18:07

Assigned:

Unassigned

» dawehner

Going to be a little blunt, and assigning it to dawehner - would love a review :)

Log in or register to post comments

Comment #2

dawehner

German

commented 28 April 2013 at 19:09

Personally it feels like we should move the description above the tags.
Description seems to be the more important than tags.

Additional this seems to disturb the visual appeal of the site that there is additional text on just one of theme.

+++ b/core/modules/views/views_ui/lib/Drupal/views_ui/Form/Ajax/EditDetails.phpundefined
@@ -44,8 +44,7 @@ public function buildForm(array $form, array &$form_state) {
+      '#title' => t('View administrative name'),

In the add view form this is just called "View name", maybe it should be the same here as well?

Log in or register to post comments

Comment #3

Bojhan commented 28 April 2013 at 19:39

Status	File	Size
new	view-name-description-admin.png	76.91 KB
new	description.position.title_.patch	2.08 KB

Ok, rerolled with the suggestions.

Log in or register to post comments

Comment #4

Bojhan commented 28 April 2013 at 20:55

Status	File	Size
new	admin-title-description-no-view.png	155.48 KB
new	admin.title_.cleanup.patch	2.08 KB

Talked this over with dawhener, we agreed that the really indicative part is the word "administrative". Given that the context is already "views" actually just using administrative should be fine.

Log in or register to post comments

Comment #5

dawehner

German

commented 29 April 2013 at 11:39

I'm not 100% sure whether we still want to have "View name and description" on the title of the modal. If we use the argument, that the context is clear, there would be no need for that, and it's maybe better to make it more consistent.

On the other hand using the same level multiple times, it's maybe annoying to read.