Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Here are a few small changes to text and titles to tidy up:
- The title of the menu item should be simply 'Scheduler' instead of 'Scheduler module settings'. Most other modules just have their name so for standards it is best to match them, and the words 'module settings' are not required.
- Change the description to actually say what can be done, because 'allow site admins to configure scheduler' gives no real help.
- Now that we have tabs, we do not need to set the titles of the pages. Other modules do not have different titles for the tabs so remove the call to drupal_set_title()
- Scheduler's own cron is referred to by several names, 'internal', 'light weight' and 'lightweight'. Most commonly it is the single word 'Lightweight' so for consistency, I suggest we change to that
patch to follow
Comment | File | Size | Author |
---|---|---|---|
#1 | 1977890_1.scheduler.tidy_up_titles.patch | 2.4 KB | jonathan1055 |
#1 | config before.jpg | 19.71 KB | jonathan1055 |
#1 | config after.jpg | 25.25 KB | jonathan1055 |
Comments
Comment #1
jonathan1055 CreditAttribution: jonathan1055 commentedHere's the patch, against 1.1 dev of 20th April
Before:
After:
I've not done screen shots of the other textual changes. This was from some old old changes I made to D6 and the patch has been sitting around and I never submitted it. Not very exciting, but it's good to tidy things up now and again.
Comment #2
rickmanelius CreditAttribution: rickmanelius commentedWorks for me. If anyone has any objections, open the ticket back up and we'll discuss. I'll commit this into the 7.x-1.2 version.
Comment #3
rickmanelius CreditAttribution: rickmanelius commentedHi jonathan1055.
Committed here:
http://drupalcode.org/project/scheduler.git/commitdiff/0d0be00?hp=024723...
Thanks!
Comment #4
jonathan1055 CreditAttribution: jonathan1055 commentedAs this is only cosmetic, I do not think we need to port to D6.