Installed navbar on a site without jQuery Update and was seeing a js error (screenshot attached), along with the shortcut tray not behaving correctly. Installing/enabling the jQuery Update module seemed to resolve the issue. Is there any reason we shouldn't list jQuery Update as a dependency?

Screen Shot 2013-04-21 at [Apr 21] 4.49.39 PM.png

CommentFileSizeAuthor
#3 navbar-jquery-shim.txt5.05 KBjessebeach
Screen Shot 2013-04-21 at [Apr 21] 4.49.39 PM.png21.52 KBmarkdorison

Comments

saltednut’s picture

saltednut
she/her
Primary language English
Location Chicago
commented

Yep - this is true. I assume initial testing was done using the Spark distro that included the proper jQuery version already.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Title: jQuery Update should be a dependency » jQuery Update should be a dependency (or, preferably, remove non jQuery 1.4 code)
Priority: Normal » Major

Hm. My understanding was that the D7 version of navbar would work OK on jQuery 1.4? Seems like we should remove the incompatible call, rather than add the dependency.

jessebeach’s picture

jessebeach commented
Status: Active » Closed (fixed)
StatusFileSize
new navbar-jquery-shim.txt5.05 KB

My understanding was that the D7 version of navbar would work OK on jQuery 1.4

Right, we don't want to force a jQuery update on D7. It's just too risky for most sites. So instead, I brought the magic of jQuery 1.7's on and off methods back to 1.4.4 with a shim! It's not ideal, but it does the job and if a site does upgrade to a version of jQuery that implements these methods, the shim will use those methods and not our polyfilled ones.

Fixed in 7.x-1.x (82c5cf2ef1f44b9550fc08c01b10371cc29af4d4).

hass’s picture

hass commented
Status: Closed (fixed) » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.